Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Visual things in modals #7660

Merged
merged 6 commits into from
Oct 17, 2023
Merged

fix: Visual things in modals #7660

merged 6 commits into from
Oct 17, 2023

Conversation

hassnian
Copy link
Contributor

@hassnian hassnian commented Oct 15, 2023

Thank you for your contribution to the KodaDot - One Stop Shop for Polkadot NFTs.

👇 __ Let's make a quick check before the contribution.

PR Type

  • Bugfix
  • Feature
  • Refactoring

Context

Did your issue had any of the "$" label on it?

  • Fill up your DOT address: Payout

Community participation

Screenshot 📸

  • My fix has changed something on UI;

CleanShot 2023-10-15 at 16 03 24@2x

Copilot Summary

🤖 Generated by Copilot at 5fd393a

Improved the styles and consistency of some modal and identity components. Adjusted the padding, alignment, and color of IdentityItem.vue, ConfirmPurchaseModal.vue, and ListingCartModal.vue.

🤖 Generated by Copilot at 5fd393a

To make the modal header look nice
They removed modal-card-head in a trice
And added some classes
For padding and axes
Like is-align-items-center and py-5

@hassnian hassnian requested a review from a team as a code owner October 15, 2023 02:51
@hassnian hassnian requested review from preschian and floyd-li and removed request for a team October 15, 2023 02:51
@netlify
Copy link

netlify bot commented Oct 15, 2023

Deploy Preview for koda-canary ready!

Name Link
🔨 Latest commit 339bc5f
🔍 Latest deploy log https://app.netlify.com/sites/koda-canary/deploys/652bc6974bd58e00081e0a1a
😎 Deploy Preview https://deploy-preview-7660--koda-canary.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@kodabot
Copy link
Collaborator

kodabot commented Oct 15, 2023

SUCCESS @hassnian PR for issue #7654 which is assigned to you. Please wait for review and don't hesitate to grab another issue in the meantime!

@reviewpad
Copy link
Contributor

reviewpad bot commented Oct 15, 2023

AI-Generated Summary: This pull request contains three patches which aim to improve the user interface and layout styling. The first patch corrects the padding in the header of the ConfirmPurchaseModal.vue file. The second patch modifies the styles in IdentityItem.vue to include k-shade as a theme and introduces more organized and specific styles. The final patch ensures proper alignment of the title in the list modal of ListingCartModal.vue. Overall, these changes improve accessibility, readability, and general visual appearance of the UI.

@reviewpad reviewpad bot added small Pull request is small waiting-for-review labels Oct 15, 2023
@hassnian
Copy link
Contributor Author

@exezbcz pls visual check

of the top section to k-shade, in dark mode k-hovergrey or k-grey

it's unclear what you mean , i changed the "connected with" label to have these colors

@exezbcz
Copy link
Member

exezbcz commented Oct 15, 2023

@exezbcz pls visual check

of the top section to k-shade, in dark mode k-hovergrey or k-grey

it's unclear what you mean , i changed the "connected with" label to have these colors

I meant the stroke of the section

image - its currently black but in the design its black

the text was okay, could you please revert these changes?

@codeclimate
Copy link

codeclimate bot commented Oct 15, 2023

Code Climate has analyzed commit 339bc5f and detected 0 issues on this pull request.

View more on Code Climate.

@sonarcloud
Copy link

sonarcloud bot commented Oct 15, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@hassnian
Copy link
Contributor Author

@exezbcz 🚀

CleanShot 2023-10-15 at 16 03 24@2x

@prury prury requested a review from exezbcz October 15, 2023 23:02
@prury prury added the S-works-for-me-✅ qa-guild has tested PR from end user perspective and functionality worked label Oct 16, 2023
@exezbcz
Copy link
Member

exezbcz commented Oct 16, 2023

It's a really small detail, but now the x-mark is not aligned on the x-axis.
image

@yangwao
Copy link
Member

yangwao commented Oct 17, 2023

pay 30 usd
thanks!
small details later 👋

@yangwao yangwao merged commit bbeb8b8 into kodadot:main Oct 17, 2023
14 checks passed
@yangwao
Copy link
Member

yangwao commented Oct 17, 2023

😍 Perfect, I’ve sent the payout
💵 $30 @ 3.73 USD/DOT ~ 8.043 $DOT
🧗 13QUj3pZyFNfYj4AM336hRdyLQbevj5H3sR4PKmLEXLdwZhh
🔗 0x96202e309304ba85b8725e27dedcbca6500f5ef7c517e6c57581c39d569b81de

🪅 Let’s grab another issue and get rewarded!
🪄 github.com/kodadot/nft-gallery/issues

@yangwao yangwao added the paid pull-request has been paid label Oct 17, 2023
This was referenced Oct 17, 2023
@exezbcz
Copy link
Member

exezbcz commented Oct 17, 2023

small details later 👋

its not really small since its the same that was before just on other side..

@exezbcz exezbcz mentioned this pull request Oct 17, 2023
This was referenced Oct 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
paid pull-request has been paid S-works-for-me-✅ qa-guild has tested PR from end user perspective and functionality worked small Pull request is small waiting-for-review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Visual things in modals
5 participants