Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Navbar logo and moving #7722

Merged
merged 2 commits into from
Oct 18, 2023
Merged

fix: Navbar logo and moving #7722

merged 2 commits into from
Oct 18, 2023

Conversation

Jarsen136
Copy link
Contributor

@Jarsen136 Jarsen136 commented Oct 18, 2023

Thank you for your contribution to the KodaDot - One Stop Shop for Polkadot NFTs.

👇 __ Let's make a quick check before the contribution.

PR Type

  • Bugfix

Needs Design check

Context

Did your issue had any of the "$" label on it?

Screenshot 📸

  • My fix has changed UI
image

Copilot Summary

🤖 Generated by Copilot at aae500f

This pull request removes the navbar-shrink class and its associated styles from the navbar component. It uses flexbox alignment instead to achieve a simpler and more consistent navbar design across different screen sizes.

🤖 Generated by Copilot at aae500f

navbar-shrink gone
Flexbox aligns the navbar
Simpler design, spring

@Jarsen136 Jarsen136 requested a review from a team as a code owner October 18, 2023 02:31
@Jarsen136 Jarsen136 requested review from roiLeo and daiagi and removed request for a team October 18, 2023 02:31
@kodabot
Copy link
Collaborator

kodabot commented Oct 18, 2023

SUCCESS @Jarsen136 PR for issue #7716 which is assigned to you. Please wait for review and don't hesitate to grab another issue in the meantime!

@netlify
Copy link

netlify bot commented Oct 18, 2023

Deploy Preview for koda-canary ready!

Name Link
🔨 Latest commit dc06014
🔍 Latest deploy log https://app.netlify.com/sites/koda-canary/deploys/652fada640e8a000088f2289
😎 Deploy Preview https://deploy-preview-7722--koda-canary.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@reviewpad reviewpad bot added small Pull request is small waiting-for-review labels Oct 18, 2023
@reviewpad
Copy link
Contributor

reviewpad bot commented Oct 18, 2023

AI-Generated Summary: This pull request includes modifications to the Navbar.vue component and _main-navigation.scss style file. The changes involve removal of 'navbar-shrink' class and its associated styles, taking away attributes like box-shadow, max-height and paddings. The class 'navbar-shrink' is also removed from the Navbar.vue file. Furthermore, a new class 'is-align-items-center' has been added to a div element in the same Vue file. This aims to fix issues with the Navbar logo and its positioning.

Copy link
Contributor

@roiLeo roiLeo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we don't need to set fixed-height on navbar-brand too

@roiLeo roiLeo added the S-code-lgtm-✅ code review guild has reviewed this PR and it's code is approved label Oct 18, 2023
@exezbcz
Copy link
Member

exezbcz commented Oct 18, 2023

works nicely, thank you

@Jarsen136
Copy link
Contributor Author

we don't need to set fixed-height on navbar-brand too

✅ Updated

@codeclimate
Copy link

codeclimate bot commented Oct 18, 2023

Code Climate has analyzed commit dc06014 and detected 0 issues on this pull request.

View more on Code Climate.

@sonarcloud
Copy link

sonarcloud bot commented Oct 18, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.9% 0.9% Duplication

@yangwao yangwao merged commit ce6a6d6 into kodadot:main Oct 18, 2023
14 checks passed
This was referenced Oct 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-code-lgtm-✅ code review guild has reviewed this PR and it's code is approved S-visual-ok-✅ small Pull request is small waiting-for-review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Navbar logo and moving
5 participants