🔧 round 2 collection card number #7723
Conversation
roiLeo
commented
Oct 18, 2023
roiLeo
commented
- closes only 2 decimal places on items #7529
roiLeo
requested review from
preschian and
Jarsen136
and removed request for
a team
✅ Deploy Preview for koda-canary ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
|
AI-Generated Summary: This pull request updates the CollectionDetail.vue component in the 'collection' directory. The changes include a minor adjustment in two instances of the 'CommonTokenMoney' component, where round attribute is added with a value of 2. This adjustment is aimed at controlling the rounding-off of the 'collectionTradedVolumeNumber' and 'collectionHighestSalePrice' values to two decimal places. |
|
Code Climate has analyzed commit b2d00df and detected 0 issues on this pull request. View more on Code Climate. |
|
Kudos, SonarCloud Quality Gate passed!
|
| @@ -27,13 +27,13 @@ | |||
| <p class="detail-item__title has-text-grey"> | |||
| {{ $t('collectionCard.volume') }} | |||
| </p> | |||
| <CommonTokenMoney :value="collectionTradedVolumeNumber" /> | |||
| <CommonTokenMoney :round="2" :value="collectionTradedVolumeNumber" /> | |||
There was a problem hiding this comment.
What if it's ksm token? It may need round 4.
There was a problem hiding this comment.
⚠️ this will round number (2 after comma) on all chains
I mean it's constraining to have a difference between chains every time
|
letsgo, next will be the usd change -> soon |
prury
added
the
S-works-for-me-✅
