fix: Current generative drops are not unlockable #7862
Conversation
✅ Deploy Preview for koda-canary ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
|
WARNING @Jarsen136 PR for issue #7843 which isn't assigned to you. Please be warned that this PR may get rejected if there's another assignee for issue #7843 |
|
AI-Generated Summary: This pull request addresses the issue with the current generative drops not being unlockable. The changes involve modifications in multiple files. A significant portion of code was removed, refactored, and consolidated into a new Vue component called The component is linked to the The |
There was a problem hiding this comment.
It looks like the api is checking if the nft is the unlockable item. Is there any idea to check if the collection is unlockable? @vikiival
#7843 (comment)
resolve/${prefix}-${nftId}
There was a problem hiding this comment.
@vikiival Could you please take a look at it?
There was a problem hiding this comment.
@vikiival Could you please take a look at it?
You have been pranked by bad naming
Usage of keywise is
const { isUnlockable, unlockLink } = useUnlockable(collection)
Therefore it is checking as
GET /resolve/${prefix}-${collectionId}
There was a problem hiding this comment.
LOL Thank you for pointing it out. I would correct the bad naming to avoid confusion.
Jarsen136
requested review from
roiLeo and
floyd-li
and removed request for
a team
|
what about this section? should we hide it for non unlockables as well? it seems now that no drop is showing this part:
as far as i know waifu drops should have and generative and kodachain should not |
prury
added
the
S-changes-requested-🤞
You're right. I have fixed them. |
|
last thing, since you've removed the unlockable section, kodachain drop needs some spacing between the footer |
|
Code Climate has analyzed commit bc14df8 and detected 0 issues on this pull request. View more on Code Climate. |
|
Kudos, SonarCloud Quality Gate passed!
|
✅ Added some spacing between them. |
prury
added
S-works-for-me-✅
KodaChain should be unlockable 🤔 |
what it should unlock? because for the waifu mints we unlock $ vouchers, but the kodachain we just give ppl the nft in case they voted for proposal |
|
Thanks! |
|
😍 Perfect, I’ve sent the payout 🪅 Let’s grab another issue and get rewarded! |
yangwao
added
paid
|
pay 30 usd |
|
😍 Perfect, I’ve sent the payout 🪅 Let’s grab another issue and get rewarded! |
Thank you for your contribution to the KodaDot - One Stop Shop for Polkadot NFTs.
👇 __ Let's make a quick check before the contribution.
PR Type
Needs QA check
Context
Did your issue had any of the "$" label on it?
Screenshot 📸
Copilot Summary
🤖 Generated by Copilot at af98ea8
This pull request refactors the drop components to simplify their structure and extract common elements, such as the unlockable item info, into reusable components. It also introduces a new component
CollectionUnlockableItemInfothat displays the unlockable content explanation based on the collection id. Additionally, it modifies theuseUnlockablecomposable to accept a more generic type for the entity parameter. These changes improve the code readability, maintainability, and flexibility.🤖 Generated by Copilot at af98ea8