Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Input same height as button #7866

Merged
merged 2 commits into from
Oct 29, 2023
Merged

fix: Input same height as button #7866

merged 2 commits into from
Oct 29, 2023

Conversation

Jarsen136
Copy link
Contributor

@Jarsen136 Jarsen136 commented Oct 28, 2023

Thank you for your contribution to the KodaDot - One Stop Shop for Polkadot NFTs.

👇 __ Let's make a quick check before the contribution.

PR Type

  • Bugfix

Needs Design check

Context

Did your issue had any of the "$" label on it?

Screenshot 📸

  • My fix has changed UI
image

Copilot Summary

🤖 Generated by Copilot at d867c3f

Fixed layout and responsiveness issues in the signup banner component by changing the style scope and a CSS class.

🤖 Generated by Copilot at d867c3f

scoped is gone, the banner is free
Unleash the power of the .fixed-height
No more constraints, no more compromise
Responsive design will rule the night

@kodabot
Copy link
Collaborator

kodabot commented Oct 28, 2023

SUCCESS @Jarsen136 PR for issue #7850 which is assigned to you. Please wait for review and don't hesitate to grab another issue in the meantime!

@netlify
Copy link

netlify bot commented Oct 28, 2023

Deploy Preview for koda-canary ready!

Name Link
🔨 Latest commit 0739053
🔍 Latest deploy log https://app.netlify.com/sites/koda-canary/deploys/653d40f7cee60a0008316413
😎 Deploy Preview https://deploy-preview-7866--koda-canary.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@Jarsen136 Jarsen136 marked this pull request as ready for review October 28, 2023 17:12
@Jarsen136 Jarsen136 requested a review from a team as a code owner October 28, 2023 17:12
@Jarsen136 Jarsen136 requested review from preschian and floyd-li and removed request for a team October 28, 2023 17:12
@reviewpad
Copy link
Contributor

reviewpad bot commented Oct 28, 2023

AI-Generated Summary: This pull request includes changes to the SignupBanner.vue component within the landing directory. The primary change is altering the .fixed-height class styling. Previously, this class was scoped and set a height of 2.5rem. The patch has moved this class within the .signup-banner class and adjusted its height to 2.25rem. Plus, the .fixed-height class is no longer scoped. This patch ensures that an input field gets the same height as a button.

@reviewpad reviewpad bot added small Pull request is small waiting-for-review labels Oct 28, 2023
@codeclimate
Copy link

codeclimate bot commented Oct 28, 2023

Code Climate has analyzed commit 0739053 and detected 0 issues on this pull request.

View more on Code Climate.

@sonarcloud
Copy link

sonarcloud bot commented Oct 28, 2023

Please retry analysis of this Pull-Request directly on SonarCloud.

@yangwao
Copy link
Member

yangwao commented Oct 29, 2023

thanks!
pay 20 usd

@yangwao yangwao merged commit e39e8f0 into kodadot:main Oct 29, 2023
15 checks passed
@yangwao
Copy link
Member

yangwao commented Oct 29, 2023

😍 Perfect, I’ve sent the payout
💵 $20 @ 4.22 USD/DOT ~ 4.739 $DOT
🧗 16SjUbGKSdjCdWTy3NNT3JxbRVGGqD4mwkHpc6BD9U2Rp29Z
🔗 0x6aad7ada7e8b057af3f0991b21f9fc6eb1ccd01516db77fc7742640440e4c2d9

🪅 Let’s grab another issue and get rewarded!
🪄 github.com/kodadot/nft-gallery/issues

@yangwao yangwao added the paid pull-request has been paid label Oct 29, 2023
This was referenced Oct 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
paid pull-request has been paid small Pull request is small waiting-for-review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Input same height as button
4 participants