Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Use more updated card as mockup #7867

Merged
merged 1 commit into from
Oct 29, 2023
Merged

Conversation

Jarsen136
Copy link
Contributor

@Jarsen136 Jarsen136 commented Oct 28, 2023

Thank you for your contribution to the KodaDot - One Stop Shop for Polkadot NFTs.

👇 __ Let's make a quick check before the contribution.

PR Type

  • Bugfix

Needs Design check

Context

Did your issue had any of the "$" label on it?

Screenshot 📸

  • My fix has changed UI
image

Copilot Summary

🤖 Generated by Copilot at 4a6bc8e

Improved the UI of the NFT creation page by adjusting the preview card component. Added a function to display the correct chain name by prefix in CreateNftPreview.vue.

🤖 Generated by Copilot at 4a6bc8e

Oh, we're the crew of the NFT ship, and we sail the blockchain sea
We make our art and we mint our cards, with a preview component
We use a function to get the chain, by the prefix that it has
And we heave and haul on the style and position, on the count of three

@Jarsen136 Jarsen136 requested a review from a team as a code owner October 28, 2023 17:48
@Jarsen136 Jarsen136 requested review from roiLeo and daiagi and removed request for a team October 28, 2023 17:48
@netlify
Copy link

netlify bot commented Oct 28, 2023

Deploy Preview for koda-canary ready!

Name Link
🔨 Latest commit 4a6bc8e
🔍 Latest deploy log https://app.netlify.com/sites/koda-canary/deploys/653d4969c55a650008e6ea09
😎 Deploy Preview https://deploy-preview-7867--koda-canary.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@kodabot
Copy link
Collaborator

kodabot commented Oct 28, 2023

SUCCESS @Jarsen136 PR for issue #7851 which is assigned to you. Please wait for review and don't hesitate to grab another issue in the meantime!

@reviewpad
Copy link
Contributor

reviewpad bot commented Oct 28, 2023

AI-Generated Summary: This pull request, titled "fix: Use more updated card as mockup", contains modifications to the CreateNftPreview.vue component. The patch includes changes in classes, divs, and functionalities for presenting the mockup card. These changes include improved style implementation, tweaks to the layout and text for better readability, as well as replacing the static import NAMES with a function getChainNameByPrefix(chain). Moreover, the changes address the responsive design by modifying the positioning of the preview card based on the screen resolution. These enhancements provide a more updated and user-friendly display of the NFT preview card.

@reviewpad reviewpad bot added the small Pull request is small label Oct 28, 2023
@codeclimate
Copy link

codeclimate bot commented Oct 28, 2023

Code Climate has analyzed commit 4a6bc8e and detected 0 issues on this pull request.

View more on Code Climate.

@sonarcloud
Copy link

sonarcloud bot commented Oct 28, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
1.0% 1.0% Duplication

@yangwao
Copy link
Member

yangwao commented Oct 29, 2023

Top Thanks!
pay 30 usd

@yangwao yangwao merged commit a422968 into kodadot:main Oct 29, 2023
15 checks passed
@yangwao
Copy link
Member

yangwao commented Oct 29, 2023

😍 Perfect, I’ve sent the payout
💵 $30 @ 4.22 USD/DOT ~ 7.109 $DOT
🧗 16SjUbGKSdjCdWTy3NNT3JxbRVGGqD4mwkHpc6BD9U2Rp29Z
🔗 0x3a21400f64c450addc8cfc305fd93ec675a60834b2da2700e7bdfb4f3fed1a64

🪅 Let’s grab another issue and get rewarded!
🪄 github.com/kodadot/nft-gallery/issues

@yangwao yangwao added the paid pull-request has been paid label Oct 29, 2023
This was referenced Oct 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
paid pull-request has been paid S-visual-ok-✅ small Pull request is small waiting-for-review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Use more updated card as mockup
4 participants