Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🔧 onboarding Markdown text #7887

Merged
merged 4 commits into from
Oct 30, 2023
Merged

🔧 onboarding Markdown text #7887

merged 4 commits into from
Oct 30, 2023

Conversation

roiLeo
Copy link
Contributor

@roiLeo roiLeo commented Oct 30, 2023 •
edited
Loading

Screenshot 2023-10-30 at 11-34-41 Massmint - Onboarding One Stop Shop for Polkadot NFTs

@roiLeo roiLeo requested a review from a team as a code owner October 30, 2023 10:36
@roiLeo roiLeo requested review from preschian and daiagi and removed request for a team October 30, 2023 10:36
@netlify
Copy link

netlify bot commented Oct 30, 2023 •
edited
Loading

✅ Deploy Preview for koda-canary ready!

Name Link
🔨 Latest commit e78b752
🔍 Latest deploy log https://app.netlify.com/sites/koda-canary/deploys/653f8cfb6c2ce000080406da
😎 Deploy Preview https://deploy-preview-7887--koda-canary.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@reviewpad
Copy link
Contributor

reviewpad bot commented Oct 30, 2023

AI-Generated Summary: This pull request includes changes in two files: GalleryCard.vue and Markdown.vue within the components directory. In GalleryCard.vue, the computed property isBasicImage has been refactored to always return true. In Markdown.vue, unused code has been removed and the instance of MarkdownIt has been modified. The highlight.js library was uncommented and used as a part of MarkdownIt's instance configuration. The configuration includes a highlight option which allows reframed use of the highlight.js functionality. This provides syntax highlighting for markdown-rendered code blocks. The changes overall seem to be focused on code cleanup and enhancing the markdown rendering functionality.

@reviewpad reviewpad bot added small Pull request is small waiting-for-review labels Oct 30, 2023
preschian
preschian reviewed Oct 30, 2023
View reviewed changes
Copy link
Member

@preschian preschian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

add allowed tag here? https://github.com/kodadot/nft-gallery/blob/main/plugins/vueHtmlSecure.ts#L7

@roiLeo
Copy link
Contributor Author

roiLeo commented Oct 30, 2023 •
edited
Loading

add allowed tag here? https://github.com/kodadot/nft-gallery/blob/main/plugins/vueHtmlSecure.ts#L7

Looks a bit different
Screenshot 2023-10-30 at 11-58-51 KodaDot - NFT Market Explorer

edit: fixed 🐛

@codeclimate
Copy link

codeclimate bot commented Oct 30, 2023

Code Climate has analyzed commit e78b752 and detected 0 issues on this pull request.

View more on Code Climate.

@sonarcloud
Copy link

sonarcloud bot commented Oct 30, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.7% 0.7% Duplication

@prury prury added the S-works-for-me-✅ qa-guild has tested PR from end user perspective and functionality worked label Oct 30, 2023
@daiagi
Copy link
Contributor

daiagi commented Oct 30, 2023

great.
would you mind adding something about the needed line gap in txt file?

@roiLeo
Copy link
Contributor Author

roiLeo commented Oct 30, 2023

great. would you mind adding something about the needed line gap in txt file?

wdym? text explaining why we need space?

@roiLeo roiLeo added this pull request to the merge queue Oct 30, 2023
Merged via the queue into kodadot:main with commit 1811572 Oct 30, 2023
14 checks passed
@roiLeo roiLeo deleted the fix/Markdown/onboarding branch October 30, 2023 12:57
@exezbcz
Copy link
Member

exezbcz commented Oct 30, 2023

@daiagi
image
yes, or maybe like comment?

@roiLeo
Copy link
Contributor Author

roiLeo commented Oct 30, 2023

yes, or maybe like comment?

IMO this can break if user copy/paste with comment (if not managed on upload).

@exezbcz
Copy link
Member

exezbcz commented Oct 30, 2023

@roiLeo true

This was referenced Nov 1, 2023
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@preschian preschian preschian approved these changes

@daiagi daiagi daiagi approved these changes

Assignees
No one assigned
Labels
S-works-for-me-✅ qa-guild has tested PR from end user perspective and functionality worked small Pull request is small waiting-for-review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

massming onboarding code block broken
5 participants
@roiLeo @daiagi @exezbcz @preschian @prury