Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: New disclaimer: Do not send to exchanges on certain networks (AH) #8149 #8180

Closed
wants to merge 0 commits into from
Closed

Conversation

AshutoshSingh00001
Copy link
Contributor

Thank you for your contribution to the KodaDot - One Stop Shop for Polkadot NFTs.

👇 __ Let's make a quick check before the contribution.

PR Type

  • Bugfix
  • Feature
  • Refactoring

Context

@AshutoshSingh00001 AshutoshSingh00001 requested a review from a team as a code owner November 21, 2023 20:22
@AshutoshSingh00001 AshutoshSingh00001 requested review from preschian and Jarsen136 and removed request for a team November 21, 2023 20:22
@kodabot
Copy link
Collaborator

kodabot commented Nov 21, 2023

SUCCESS @AshutoshSingh00001 PR for issue #8149 which is assigned to you. Please wait for review and don't hesitate to grab another issue in the meantime!

Copy link

netlify bot commented Nov 21, 2023

Deploy Preview for koda-canary ready!

Name Link
🔨 Latest commit 0c3ed09
🔍 Latest deploy log https://app.netlify.com/sites/koda-canary/deploys/6561b7c6ed40a8000873b8da
😎 Deploy Preview https://deploy-preview-8180--koda-canary.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@reviewpad reviewpad bot added small Pull request is small waiting-for-review labels Nov 21, 2023
Copy link
Contributor

reviewpad bot commented Nov 21, 2023

AI-Generated Summary: This pull request introduces several changes to the Transfer.vue and en.json files. The changes in Transfer.vue include the addition of a new info-tooltip and warning exchange toggle, along with corresponding logic for managing the tooltip and switch states. The "continue" button has also been updated to be disabled not only when a "disabled" condition is met, but also when the warning exchange toggle is turned off. The reference variable 'warningexchange' has been renamed to 'warningExchange' for better readability. In addition, a new warning message, "Do not send tokens to centralized exchanges", has been added to the en.json file for localization purposes.

@AshutoshSingh00001 AshutoshSingh00001 changed the title Transfer: New disclaimer: Do not send to exchanges on certain networks (AH) #8149 Fix: New disclaimer: Do not send to exchanges on certain networks (AH) #8149 Nov 21, 2023
@AshutoshSingh00001
Copy link
Contributor Author

@JustLuuuu @prury please review

@JustLuuuu
Copy link
Member

@AshutoshSingh00001

I wanted to drop my bit here.

  • It's not very clear why people should not send the funds to exchange.
  • We are not offering any solution to them (what should they do if they want to send funds to exchange?)
  • The hovering info point has the same text as the main text.
  • I would put a different text under the info circle: Something like if you are sending your funds from Assethub to exchange, your funds may be permanently lost; teleport them before sending. Or something in this style
Screenshot 2023-11-22 at 18 00 43

@AshutoshSingh00001
Copy link
Contributor Author

@AshutoshSingh00001

I wanted to drop my bit here.

  • It's not very clear why people should not send the funds to exchange.
  • We are not offering any solution to them (what should they do if they want to send funds to exchange?)
  • The hovering info point has the same text as the main text.
  • I would put a different text under the info circle: Something like if you are sending your funds from Assethub to exchange, your funds may be permanently lost; teleport them before sending. Or something in this style
Screenshot 2023-11-22 at 18 00 43

thanks for the reply @JustLuuuu
i'lll be updating my pr according to your needs

@JustLuuuu
Copy link
Member

AAA text ran away from the info box 😂
Screenshot 2023-11-22 at 18 56 29

@prury prury added the S-changes-requested-🤞 PR is almost good to go, just some fine tunning label Nov 22, 2023
@prury
Copy link
Member

prury commented Nov 22, 2023

mobile needs work as well:
image

@exezbcz
Copy link
Member

exezbcz commented Nov 23, 2023

Uf, I'm not sure about this.

Sorry, but I did not drop any instructions, now it's just a random toggle button that does not make sense.

#8149 (comment)

Copy link

codeclimate bot commented Nov 25, 2023

Code Climate has analyzed commit 97cf8b8 and detected 0 issues on this pull request.

View more on Code Climate.

Copy link

sonarcloud bot commented Nov 25, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs S-changes-requested-🤞 PR is almost good to go, just some fine tunning small Pull request is small waiting-for-review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Transfer: New disclaimer: Do not send to exchanges on certain networks (AH)
5 participants