Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stuck at claim of Chroma drop #8619 #8624

Merged
merged 2 commits into from
Dec 16, 2023
Merged

Conversation

hassnian
Copy link
Contributor

PR Type

  • Bugfix
  • Feature
  • Refactoring

Context

Did your issue had any of the "$" label on it?

  • Fill up your DOT address: Payout

Community participation

Screenshot 📸

  • My fix has changed something on UI;

Copilot Summary

copilot:summary

copilot:poem

@hassnian hassnian requested a review from a team as a code owner December 16, 2023 14:22
@hassnian hassnian requested review from preschian and roiLeo and removed request for a team December 16, 2023 14:22
@kodabot
Copy link
Collaborator

kodabot commented Dec 16, 2023

WARNING @hassnian PR for issue #8482 which isn't assigned to you. Please be warned that this PR may get rejected if there's another assignee for issue #8482

@kodabot
Copy link
Collaborator

kodabot commented Dec 16, 2023

WARNING @hassnian PR for issue #8526 which isn't assigned to you. Please be warned that this PR may get rejected if there's another assignee for issue #8526

Copy link

netlify bot commented Dec 16, 2023

Deploy Preview for koda-canary ready!

Name Link
🔨 Latest commit f14e663
🔍 Latest deploy log https://app.netlify.com/sites/koda-canary/deploys/657dbae36da8fd0008dce15d
😎 Deploy Preview https://deploy-preview-8624--koda-canary.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@kodabot
Copy link
Collaborator

kodabot commented Dec 16, 2023

WARNING @hassnian PR for issue #8619 which isn't assigned to you. Please be warned that this PR may get rejected if there's another assignee for issue #8619

@reviewpad reviewpad bot added small Pull request is small waiting-for-review labels Dec 16, 2023
@yangwao
Copy link
Member

yangwao commented Dec 16, 2023

I see conflicts @hassnian happy to test!

Copy link
Contributor

reviewpad bot commented Dec 16, 2023

AI-Generated Summary: This pull request addresses a bug where a modal was getting stuck in the application. In the 'AddFundsModal.vue' and 'AutoTeleportActionButton.vue' components, the developer modifies the condition for setting the loading state and showing add funds methods respectively, by checking for the isReady property instead of hasBalances of the autoteleport data object. This makes the UI dependent on the readiness of the autoteleport data instead of the presence of its balances data.

Furthermore, the developer makes changes to the useAutoTeleportTransitionDetails.ts composable function, to include a balances boolean in the fetched object. This boolean is false when we start fetching the transition balances and true when it ends - consequently affecting the hasBalances computed property which now relies on the balances having been fetched.

Overall, the changes in this pull request ensure that certain parts of the UI are updated based on the readiness of autoteleport data and completion of the fetching of transition balances.

@yangwao
Copy link
Member

yangwao commented Dec 16, 2023

ok worked for me tho.

we can extend it with mint if so then? for follow up I guess

image

@yangwao
Copy link
Member

yangwao commented Dec 16, 2023

@hassnian let's resolve conflicts if you figure it out, it worked for me! 😄

@reviewpad reviewpad bot added large Pull request is large and removed small Pull request is small labels Dec 16, 2023
@@ -83,3 +85,40 @@ export const useDropStatus = (id: string) => {
fetchDropStatus,
}
}

export const useDropMinimumFunds = (drop) => {
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Function useDropMinimumFunds has 29 lines of code (exceeds 25 allowed). Consider refactoring.

Copy link

codeclimate bot commented Dec 16, 2023

Code Climate has analyzed commit f14e663 and detected 1 issue on this pull request.

Here's the issue category breakdown:

Category Count
Complexity 1

View more on Code Climate.

Copy link

sonarcloud bot commented Dec 16, 2023

Quality Gate Passed Quality Gate passed

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@yangwao yangwao merged commit 45606d3 into kodadot:main Dec 16, 2023
14 of 15 checks passed
@yangwao
Copy link
Member

yangwao commented Dec 16, 2023

Thanks!
pay 30 usd

@yangwao
Copy link
Member

yangwao commented Dec 16, 2023

😍 Perfect, I’ve sent the payout
💵 $30 @ 7.2 USD/DOT ~ 4.167 $DOT
🧗 13QUj3pZyFNfYj4AM336hRdyLQbevj5H3sR4PKmLEXLdwZhh
🔗 0xae5c0a58b2a752e403c6a4e485542e8cdb9889682296881c14cb3396549d43cc

🪅 Let’s grab another issue and get rewarded!
🪄 github.com/kodadot/nft-gallery/issues

@yangwao yangwao added the paid pull-request has been paid label Dec 16, 2023
This was referenced Dec 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
large Pull request is large paid pull-request has been paid waiting-for-review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Stuck at claim of Chroma drop Check ED on auto teleport Drops requiring funds to enable auto-teleport
3 participants