Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Auto teleport tooltip #8821

Merged
merged 1 commit into from
Jan 2, 2024
Merged

fix: Auto teleport tooltip #8821

merged 1 commit into from
Jan 2, 2024

Conversation

hassnian
Copy link
Contributor

@hassnian hassnian commented Jan 2, 2024

PR Type

  • Bugfix
  • Feature
  • Refactoring

Context

Did your issue had any of the "$" label on it?

  • Fill up your DOT address: Payout

Community participation

Screenshot 📸

  • My fix has changed something on UI;

CleanShot 2024-01-02 at 13 37 52

CleanShot 2024-01-02 at 13 40 13

@kodabot
Copy link
Collaborator

kodabot commented Jan 2, 2024

SUCCESS @hassnian PR for issue #8820 which is assigned to you. Please wait for review and don't hesitate to grab another issue in the meantime!

Copy link

netlify bot commented Jan 2, 2024

Deploy Preview for koda-canary ready!

Name Link
🔨 Latest commit d890ba5
🔍 Latest deploy log https://app.netlify.com/sites/koda-canary/deploys/6593c7a15a104400087f7174
😎 Deploy Preview https://deploy-preview-8821--koda-canary.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Contributor

reviewpad bot commented Jan 2, 2024

AI-Generated Summary: This pull request introduces a change in the tooltip implementation for the 'autoTeleport' feature in the application. The AutoTeleportTooltip component is replaced with a new AutoTeleportPopover component. This new component uses tippy for the popover functionality.

The patch includes the creation of the new AutoTeleportPopover component, with corresponding template, Vue.js script and SCSS configuration. The 'AutoTeleportActionButton' component is also updated to replace occurrences of the AutoTeleportTooltip with the new AutoTeleportPopover.

Also, the AutoTeleportTooltip component has been deleted as it is no longer required.

Overall, this should yield a smoother and enhanced user experience in the Auto Teleport feature segment.

@reviewpad reviewpad bot added the medium Pull request is medium label Jan 2, 2024
Copy link

codeclimate bot commented Jan 2, 2024

Code Climate has analyzed commit d890ba5 and detected 0 issues on this pull request.

View more on Code Climate.

Copy link

sonarcloud bot commented Jan 2, 2024

Quality Gate Passed Quality Gate passed

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@hassnian hassnian marked this pull request as ready for review January 2, 2024 08:29
@hassnian hassnian requested a review from a team as a code owner January 2, 2024 08:29
@hassnian hassnian requested review from preschian and Jarsen136 and removed request for a team January 2, 2024 08:29
@hassnian
Copy link
Contributor Author

hassnian commented Jan 2, 2024

@exezbcz please review

Copy link
Contributor

@roiLeo roiLeo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is v-tippy better than NeoTooltip?
should we use only one of the tooltip component?

@roiLeo roiLeo requested a review from exezbcz January 2, 2024 09:50
@hassnian
Copy link
Contributor Author

hassnian commented Jan 2, 2024

is v-tippy better than NeoTooltip? should we use only one of the tooltip component?

first time using v-tippy , so idk , seems to be better in some aspects but we are only using it in 3 places

The only reason I ended up using v-tippy it's because I couldn't get the same behaviour using the oruga component.

using only one would good idea though

@exezbcz
Copy link
Member

exezbcz commented Jan 2, 2024

yup looks good thanks!

one issue i came across is this now. Not sure if related to the deploy, but this does not seem right

image
image
image

seems like its also a canary issue

the autoteleport should not be active

my address:
14JipEfjkyFEe4jRViuqFomLPBz96SEXKGcYVkCcfqbAqAxU
nft:
https://canary.kodadot.xyz/ahp/gallery/50-533

@exezbcz exezbcz mentioned this pull request Jan 2, 2024
@hassnian
Copy link
Contributor Author

hassnian commented Jan 2, 2024

yup looks good thanks!

@exezbcz can you add the visual ok tag

thanks ;D

Comment on lines +81 to +83
@include ktheme() {
background: theme('background-color');
}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please check theme-background-color at global.scss

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we can do follow up

@prury prury added the S-works-for-me-✅ qa-guild has tested PR from end user perspective and functionality worked label Jan 2, 2024
@yangwao
Copy link
Member

yangwao commented Jan 2, 2024

Thanks!
pay 30 usd

@yangwao yangwao merged commit 7d58848 into kodadot:main Jan 2, 2024
15 checks passed
@yangwao
Copy link
Member

yangwao commented Jan 2, 2024

😍 Perfect, I’ve sent the payout
💵 $30 @ 8.58 USD/DOT ~ 3.497 $DOT
🧗 13QUj3pZyFNfYj4AM336hRdyLQbevj5H3sR4PKmLEXLdwZhh
🔗 0xb96543f954d0b07062092e7f3bfdb7b86fa852db0d12e6973ec4f3abadc9b0af

🪅 Let’s grab another issue and get rewarded!
🪄 github.com/kodadot/nft-gallery/issues

@yangwao yangwao added the paid pull-request has been paid label Jan 2, 2024
This was referenced Jan 4, 2024
This was referenced Jan 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
medium Pull request is medium paid pull-request has been paid S-visual-ok-✅ S-works-for-me-✅ qa-guild has tested PR from end user perspective and functionality worked waiting-for-review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Auto teleport tooltip Auto-teleport in confirm modal simplified follow-up
7 participants