-
-
Notifications
You must be signed in to change notification settings - Fork 353
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Auto teleport tooltip #8821
Conversation
✅ Deploy Preview for koda-canary ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
AI-Generated Summary: This pull request introduces a change in the tooltip implementation for the 'autoTeleport' feature in the application. The The patch includes the creation of the new Also, the Overall, this should yield a smoother and enhanced user experience in the Auto Teleport feature segment. |
Code Climate has analyzed commit d890ba5 and detected 0 issues on this pull request. View more on Code Climate. |
|
@exezbcz please review |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
is v-tippy
better than NeoTooltip
?
should we use only one of the tooltip component?
first time using v-tippy , so idk , seems to be better in some aspects but we are only using it in 3 places The only reason I ended up using v-tippy it's because I couldn't get the same behaviour using the oruga component. using only one would good idea though |
yup looks good thanks! one issue i came across is this now. Not sure if related to the deploy, but this does not seem right seems like its also a canary issue the autoteleport should not be active my address: |
@exezbcz can you add the visual ok tag thanks ;D |
@include ktheme() { | ||
background: theme('background-color'); | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please check theme-background-color
at global.scss
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
we can do follow up
Thanks! |
😍 Perfect, I’ve sent the payout 🪅 Let’s grab another issue and get rewarded! |
PR Type
Context
use tippy instate of NeoTooltip
fixed vertical margins
renamed file from AutotelportTooltip to AutotelportPopever
Closes Auto teleport tooltip #8820
Closes Auto-teleport in confirm modal simplified follow-up #8451
Did your issue had any of the "$" label on it?
Community participation
Screenshot 📸