Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Cart notification #9052

Merged
merged 2 commits into from
Jan 19, 2024
Merged

fix: Cart notification #9052

merged 2 commits into from
Jan 19, 2024

Conversation

Jarsen136
Copy link
Contributor

Thank you for your contribution to the KodaDot - One Stop Shop for Polkadot NFTs.

👇 __ Let's make a quick check before the contribution.

PR Type

  • Bugfix

Needs Design check

Context

Did your issue had any of the "$" label on it?

Screenshot 📸

  • My fix has changed UI
image

Copilot Summary

copilot:summary

copilot:poem

@Jarsen136 Jarsen136 requested a review from a team as a code owner January 19, 2024 06:16
@Jarsen136 Jarsen136 requested review from preschian and roiLeo and removed request for a team January 19, 2024 06:16
Copy link

netlify bot commented Jan 19, 2024

Deploy Preview for koda-canary ready!

Name Link
🔨 Latest commit 1d9d100
🔍 Latest deploy log https://app.netlify.com/sites/koda-canary/deploys/65aa2fec97eb860008f8bb22
😎 Deploy Preview https://deploy-preview-9052--koda-canary.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@kodabot
Copy link
Collaborator

kodabot commented Jan 19, 2024

SUCCESS @Jarsen136 PR for issue #9046 which is assigned to you. Please wait for review and don't hesitate to grab another issue in the meantime!

@reviewpad reviewpad bot added small Pull request is small waiting-for-review labels Jan 19, 2024
Copy link
Contributor

reviewpad bot commented Jan 19, 2024

AI-Generated Summary: This pull request includes changes made to two Vue component files - 'ActiveCount.vue' and 'ShoppingCartButton.vue'. Specifically, it modifies the visual features related to the shopping cart notification. In 'ActiveCount.vue', the size and rounding of the notification display have been tweaked. Similarly, in 'ShoppingCartButton.vue', the positioning style of the shopping cart notification count is adjusted, while the '.count-position' style is removed in the SCSS section. The changes aim to fix some issues related to the cart notification display.

Co-authored-by: roiLeo <medina.leo42@gmail.com>
Copy link

codeclimate bot commented Jan 19, 2024

Code Climate has analyzed commit 1d9d100 and detected 0 issues on this pull request.

View more on Code Climate.

Copy link

sonarcloud bot commented Jan 19, 2024

Quality Gate Passed Quality Gate passed

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
No data about Coverage
0.6% Duplication on New Code

See analysis details on SonarCloud

@roiLeo roiLeo added the S-code-lgtm-✅ code review guild has reviewed this PR and it's code is approved label Jan 19, 2024
@yangwao
Copy link
Member

yangwao commented Jan 19, 2024

thanks!
pay 20 usd

@yangwao yangwao merged commit d908b35 into kodadot:main Jan 19, 2024
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-code-lgtm-✅ code review guild has reviewed this PR and it's code is approved small Pull request is small waiting-for-review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Cart notification
4 participants