Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Weird hover in connect wallet #9081

Merged
merged 4 commits into from
Jan 22, 2024
Merged

Conversation

hassnian
Copy link
Contributor

@hassnian hassnian commented Jan 21, 2024

PR Type

  • Bugfix
  • Feature
  • Refactoring

Needs Design check

Context

Did your issue had any of the "$" label on it?

  • Fill up your DOT address: Payout

Screenshot 📸

  • My fix has changed something on UI;

CleanShot 2024-01-21 at 10 50 32

CleanShot 2024-01-21 at 10 51 12

@hassnian hassnian requested a review from a team as a code owner January 21, 2024 05:50
@hassnian hassnian requested review from preschian and roiLeo and removed request for a team January 21, 2024 05:50
Copy link

netlify bot commented Jan 21, 2024

Deploy Preview for koda-canary ready!

Name Link
🔨 Latest commit 0056b35
🔍 Latest deploy log https://app.netlify.com/sites/koda-canary/deploys/65ae003e9cc6000008f068a1
😎 Deploy Preview https://deploy-preview-9081--koda-canary.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@kodabot
Copy link
Collaborator

kodabot commented Jan 21, 2024

WARNING @hassnian PR for issue #9058 which isn't assigned to you. Please be warned that this PR may get rejected if there's another assignee for issue #9058

Copy link
Contributor

reviewpad bot commented Jan 21, 2024

AI-Generated Summary: This pull request contains a minor CSS change in the "_connect-wallet.scss" file. The modification is concerned with the button styling within the ".wallet-menu-item" class. Instead of using the invalid syntax "border-[none]", it has been corrected to use "border-none". This change will ensure that the button will not show any border when hovered over.

@reviewpad reviewpad bot added small Pull request is small waiting-for-review labels Jan 21, 2024
@exezbcz
Copy link
Member

exezbcz commented Jan 21, 2024

nice!

one side comment, any idea why it now has different animation from the subselection hover?
image
image

Copy link

codeclimate bot commented Jan 22, 2024

Code Climate has analyzed commit 0056b35 and detected 0 issues on this pull request.

View more on Code Climate.

@hassnian
Copy link
Contributor Author

hassnian commented Jan 22, 2024

one side comment, any idea why it now has different animation from the subselection hover?

@exezbcz fixed

CleanShot 2024-01-22 at 10 42 26

Copy link

sonarcloud bot commented Jan 22, 2024

Quality Gate Passed Quality Gate passed

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@yangwao
Copy link
Member

yangwao commented Jan 22, 2024

thanks!
pay 20 usd

@yangwao yangwao merged commit f662c2f into kodadot:main Jan 22, 2024
15 checks passed
@yangwao
Copy link
Member

yangwao commented Jan 22, 2024

😍 Perfect, I’ve sent the payout
💵 $20 @ 6.67 USD/DOT ~ 2.999 $DOT
🧗 16faLfsywwNATaEfbH2ah75dn6ZmctQWpMS5G4KFhbmj5hnD
🔗 0x772f19b5a5832bf108706f9c93d27c41eccdfbbea30ec9a8bf5c746f6b1e045e

🪅 Let’s grab another issue and get rewarded!
🪄 github.com/kodadot/nft-gallery/issues

@yangwao yangwao added the paid pull-request has been paid label Jan 22, 2024
This was referenced Jan 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
paid pull-request has been paid S-visual-ok-✅ small Pull request is small waiting-for-review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Weird hover in connect wallet
5 participants