Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: top collection mobile chain dropdown #9098

Merged
merged 2 commits into from
Jan 22, 2024
Merged

Conversation

hassnian
Copy link
Contributor

@hassnian hassnian commented Jan 22, 2024

PR Type

  • Bugfix
  • Feature
  • Refactoring

Needs Design check

Context

Did your issue had any of the "$" label on it?

  • Fill up your DOT address: Payout

Screenshot 📸

  • My fix has changed something on UI;

mobile

CleanShot 2024-01-22 at 08 12 33@2x

desktop
CleanShot 2024-01-22 at 08 13 49@2x

@hassnian hassnian requested a review from a team as a code owner January 22, 2024 03:12
@hassnian hassnian requested review from preschian and Jarsen136 and removed request for a team January 22, 2024 03:12
Copy link

netlify bot commented Jan 22, 2024

Deploy Preview for koda-canary ready!

Name Link
🔨 Latest commit f76f5fa
🔍 Latest deploy log https://app.netlify.com/sites/koda-canary/deploys/65ade22d72fae5000878dfc5
😎 Deploy Preview https://deploy-preview-9098--koda-canary.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@kodabot
Copy link
Collaborator

kodabot commented Jan 22, 2024

WARNING @hassnian PR for issue #9092 which isn't assigned to you. Please be warned that this PR may get rejected if there's another assignee for issue #9092

@reviewpad reviewpad bot added small Pull request is small waiting-for-review labels Jan 22, 2024
Copy link
Contributor

reviewpad bot commented Jan 22, 2024

AI-Generated Summary: This pull request includes changes in two Vue.js components: ChainDropdown.vue and TopCollections.vue. The main modification involves fixing the dropdown behavior in mobile views. In ChainDropdown.vue, the mobileModal prop has been removed and the position prop's possible values have been extended to include 'bottom-right'. Correspondingly, in TopCollections.vue, the position values of the ChainDropdown are dynamically set based on whether the device is mobile or not. This dynamic behavior is achieved by using the isMobile condition derived from useViewport(). Lastly, the mobile-modal property has been dropped from ChainDropdown in TopCollections.vue.

Copy link

codeclimate bot commented Jan 22, 2024

Code Climate has analyzed commit f76f5fa and detected 0 issues on this pull request.

View more on Code Climate.

Copy link

sonarcloud bot commented Jan 22, 2024

Quality Gate Passed Quality Gate passed

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@yangwao
Copy link
Member

yangwao commented Jan 22, 2024

thanks!
pay 20 usd

@yangwao yangwao merged commit 0f0ebfa into kodadot:main Jan 22, 2024
15 checks passed
@yangwao
Copy link
Member

yangwao commented Jan 22, 2024

😍 Perfect, I’ve sent the payout
💵 $20 @ 6.66 USD/DOT ~ 3.003 $DOT
🧗 16faLfsywwNATaEfbH2ah75dn6ZmctQWpMS5G4KFhbmj5hnD
🔗 0x5ac131652f547603b6326c0e963afad64bbcda8fd7c72db4892ab493a07bdd3e

🪅 Let’s grab another issue and get rewarded!
🪄 github.com/kodadot/nft-gallery/issues

@yangwao yangwao added the paid pull-request has been paid label Jan 22, 2024
This was referenced Jan 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
paid pull-request has been paid small Pull request is small waiting-for-review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Dropdown = dropdown on mobile
4 participants