Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: link color override #9099

Merged
merged 4 commits into from
Jan 23, 2024
Merged

fix: link color override #9099

merged 4 commits into from
Jan 23, 2024

Conversation

Jarsen136
Copy link
Contributor

@Jarsen136 Jarsen136 commented Jan 22, 2024

Thank you for your contribution to the KodaDot - One Stop Shop for Polkadot NFTs.

👇 __ Let's make a quick check before the contribution.

PR Type

  • Bugfix

Needs Design check

Context

Did your issue had any of the "$" label on it?

Screenshot 📸

  • My fix has changed UI
image

Copilot Summary

copilot:summary

copilot:poem

@Jarsen136 Jarsen136 requested a review from a team as a code owner January 22, 2024 03:42
@Jarsen136 Jarsen136 requested review from preschian and roiLeo and removed request for a team January 22, 2024 03:42
Copy link

netlify bot commented Jan 22, 2024

Deploy Preview for koda-canary ready!

Name Link
🔨 Latest commit d8fc785
🔍 Latest deploy log https://app.netlify.com/sites/koda-canary/deploys/65af6ad8ca2f5d00085fd6e6
😎 Deploy Preview https://deploy-preview-9099--koda-canary.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@kodabot
Copy link
Collaborator

kodabot commented Jan 22, 2024

WARNING @Jarsen136 PR for issue #9095 which isn't assigned to you. Please be warned that this PR may get rejected if there's another assignee for issue #9095

Copy link
Contributor

reviewpad bot commented Jan 22, 2024

AI-Generated Summary: This pull request contains changes to the global.scss file in the assets/styles directory. The main modification is on the link color property. The color value is now assigned not only based on the theme's 'text-color' but also excludes references with the class '.text-k-grey'. This ensures that the link color isn't overridden by the '.text-k-grey' class.

@reviewpad reviewpad bot added small Pull request is small waiting-for-review labels Jan 22, 2024
Copy link
Contributor

@roiLeo roiLeo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this clearly look like a hotfix, would you mind migrate this part to Tailwind?

@yangwao
Copy link
Member

yangwao commented Jan 22, 2024

would you mind migrate this part to Tailwind?

good idea, @Jarsen136 ? I mean it's not urgent or important fix so can be migrated if so :)

@yangwao yangwao added the S-changes-requested-🤞 PR is almost good to go, just some fine tunning label Jan 22, 2024
@Jarsen136
Copy link
Contributor Author

would you mind migrate this part to Tailwind?

good idea, @Jarsen136 ? I mean it's not urgent or important fix so can be migrated if so :)

✅ It's a good idea. Updated

@Jarsen136 Jarsen136 requested a review from roiLeo January 22, 2024 14:19
Copy link

codeclimate bot commented Jan 23, 2024

Code Climate has analyzed commit d8fc785 and detected 0 issues on this pull request.

View more on Code Climate.

Copy link

sonarcloud bot commented Jan 23, 2024

Quality Gate Passed Quality Gate passed

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
No data about Coverage
0.6% Duplication on New Code

See analysis details on SonarCloud

@yangwao
Copy link
Member

yangwao commented Jan 23, 2024

Thanks!
pay 30 usd

@yangwao yangwao merged commit 002ffc1 into kodadot:main Jan 23, 2024
14 of 15 checks passed
@yangwao
Copy link
Member

yangwao commented Jan 23, 2024

😍 Perfect, I’ve sent the payout
💵 $30 @ 6.06 USD/DOT ~ 4.95 $DOT
🧗 16SjUbGKSdjCdWTy3NNT3JxbRVGGqD4mwkHpc6BD9U2Rp29Z
🔗 0xf434ce0785efeee176e5d4a22896b59aa576c04e367de06c87701e94b0bbf54b

🪅 Let’s grab another issue and get rewarded!
🪄 github.com/kodadot/nft-gallery/issues

@yangwao yangwao added the paid pull-request has been paid label Jan 23, 2024
This was referenced Jan 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
paid pull-request has been paid S-changes-requested-🤞 PR is almost good to go, just some fine tunning small Pull request is small waiting-for-review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Settings active in profile sidebar?
5 participants