Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🇮🇳 hindi translation #9118

Merged
merged 5 commits into from
Jan 24, 2024
Merged

🇮🇳 hindi translation #9118

merged 5 commits into from
Jan 24, 2024

Conversation

roiLeo
Copy link
Contributor

@roiLeo roiLeo commented Jan 24, 2024

@roiLeo roiLeo requested a review from a team as a code owner January 24, 2024 07:50
@roiLeo roiLeo requested review from preschian and Jarsen136 and removed request for a team January 24, 2024 07:50
Copy link

netlify bot commented Jan 24, 2024

Deploy Preview for koda-canary ready!

Name Link
🔨 Latest commit 14b02a7
🔍 Latest deploy log https://app.netlify.com/sites/koda-canary/deploys/65b1160cb278820009b455c1
😎 Deploy Preview https://deploy-preview-9118--koda-canary.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@reviewpad reviewpad bot added large Pull request is large waiting-for-review labels Jan 24, 2024
Copy link
Contributor

reviewpad bot commented Jan 24, 2024

Reviewpad Report

⚠️ Warnings

  • Please link an issue to the pull request

Copy link
Contributor

reviewpad bot commented Jan 24, 2024

AI-Generated Summary: This pull request updates the file utils/config/i18n.ts to include support for the Hindi (हिंदी) language. A new data object containing the value (hi), flag (🇮🇳), and label (हिंदी) for Hindi has been added to the langsFlags array.

@yangwao
Copy link
Member

yangwao commented Jan 24, 2024

I mean we are missing some key keys

Screenshot_20240124_085757_Chrome.jpg

@roiLeo
Copy link
Contributor Author

roiLeo commented Jan 24, 2024

@yangwao why merge the other one? now I have load of conflicts..

@reviewpad reviewpad bot added small Pull request is small and removed large Pull request is large labels Jan 24, 2024
@yangwao
Copy link
Member

yangwao commented Jan 24, 2024

why merge the other one? now I have load of conflicts..

image

thought it's follow, we can revert than 9088 ?

@yangwao
Copy link
Member

yangwao commented Jan 24, 2024

let's @roiLeo resolve it please, feel revert anything on your own, thought want to push it to production :)

@roiLeo
Copy link
Contributor Author

roiLeo commented Jan 24, 2024

why merge the other one? now I have load of conflicts..

image

thought it's follow, we can revert than 9088 ?

I should have close the other one but didn't want to have the basic conversation about why I close PR. (since it was not completed)

let's @roiLeo resolve it please, feel revert anything on your own, thought want to push it to production :)

Now I loose all my changes and we are back on duplicated key:value

will try to fix it again but it's a bit annoying ☹️

Copy link

sonarcloud bot commented Jan 24, 2024

Quality Gate Passed Quality Gate passed

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

Copy link

codeclimate bot commented Jan 24, 2024

Code Climate has analyzed commit 14b02a7 and detected 0 issues on this pull request.

View more on Code Climate.

@roiLeo
Copy link
Contributor Author

roiLeo commented Jan 24, 2024

Aight sorry for the salty comment, should be good now.

@yangwao
Copy link
Member

yangwao commented Jan 24, 2024

will try to fix it again but it's a bit annoying ☹️

sorry for misscordination

friends, again?

@roiLeo
Copy link
Contributor Author

roiLeo commented Jan 24, 2024

it's kind of my fault anyway, let's move on

ohyoushiba

@yangwao
Copy link
Member

yangwao commented Jan 24, 2024

@roiLeo can merge?

@yangwao yangwao added the S-code-lgtm-✅ code review guild has reviewed this PR and it's code is approved label Jan 24, 2024
@roiLeo
Copy link
Contributor Author

roiLeo commented Jan 24, 2024

@roiLeo can merge?

yessir 🚀

@yangwao
Copy link
Member

yangwao commented Jan 24, 2024

@yangwao yangwao merged commit ad1e53e into main Jan 24, 2024
15 checks passed
@yangwao yangwao deleted the TouchstoneTheDev/main branch January 24, 2024 14:43
This was referenced Jan 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-code-lgtm-✅ code review guild has reviewed this PR and it's code is approved small Pull request is small waiting-for-review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants