Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Small things in the hover card #9134

Merged
merged 1 commit into from
Jan 25, 2024
Merged

Conversation

Jarsen136
Copy link
Contributor

Thank you for your contribution to the KodaDot - One Stop Shop for Polkadot NFTs.

👇 __ Let's make a quick check before the contribution.

PR Type

  • Bugfix

Needs Design check

Context

Did your issue had any of the "$" label on it?

Screenshot 📸

  • My fix has changed UI
image

Copilot Summary

copilot:summary

copilot:poem

@Jarsen136 Jarsen136 requested a review from a team as a code owner January 25, 2024 05:25
@Jarsen136 Jarsen136 requested review from preschian and roiLeo and removed request for a team January 25, 2024 05:25
Copy link

netlify bot commented Jan 25, 2024

Deploy Preview for koda-canary ready!

Name Link
🔨 Latest commit ad77a7d
🔍 Latest deploy log https://app.netlify.com/sites/koda-canary/deploys/65b1f0b2175c6a0008bcf97e
😎 Deploy Preview https://deploy-preview-9134--koda-canary.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@kodabot
Copy link
Collaborator

kodabot commented Jan 25, 2024

SUCCESS @Jarsen136 PR for issue #9130 which is assigned to you. Please wait for review and don't hesitate to grab another issue in the meantime!

Copy link
Contributor

reviewpad bot commented Jan 25, 2024

AI-Generated Summary: This pull request includes changes in two vue components - MediaItem.vue and GalleryCard.vue. In the MediaItem component, a CSS class is updated to include 'text-text-color' in an element when it is interactive. In the GalleryCard.vue component, the 'card nft-card' div has been assigned an additional CSS class 'rounded-none'. Furthermore, a new CSS class, 'border border-k-grey', was added to div with the class 'card-image'. These adjustments appear to be done for styling and visual purposes.

@reviewpad reviewpad bot added small Pull request is small waiting-for-review labels Jan 25, 2024
Copy link

codeclimate bot commented Jan 25, 2024

Code Climate has analyzed commit ad77a7d and detected 0 issues on this pull request.

View more on Code Climate.

Copy link

sonarcloud bot commented Jan 25, 2024

Quality Gate Passed Quality Gate passed

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
No data about Coverage
0.6% Duplication on New Code

See analysis details on SonarCloud

@preschian preschian added the S-code-lgtm-✅ code review guild has reviewed this PR and it's code is approved label Jan 25, 2024
@yangwao
Copy link
Member

yangwao commented Jan 25, 2024

thanks!
pay 20 usd

@yangwao yangwao merged commit 88d57e3 into kodadot:main Jan 25, 2024
15 checks passed
@yangwao
Copy link
Member

yangwao commented Jan 25, 2024

😍 Perfect, I’ve sent the payout
💵 $20 @ 6.43 USD/DOT ~ 3.11 $DOT
🧗 16SjUbGKSdjCdWTy3NNT3JxbRVGGqD4mwkHpc6BD9U2Rp29Z
🔗 0x7394a7625fdf6bea4401a52bc965f211fda828bed50ee12ca04c5d40bd777c45

🪅 Let’s grab another issue and get rewarded!
🪄 github.com/kodadot/nft-gallery/issues

@yangwao yangwao added the paid pull-request has been paid label Jan 25, 2024
This was referenced Feb 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
paid pull-request has been paid S-code-lgtm-✅ code review guild has reviewed this PR and it's code is approved small Pull request is small waiting-for-review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Small things in the hover card
4 participants