Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Party kit followups #9439

Merged
merged 13 commits into from
Feb 17, 2024
Merged

fix: Party kit followups #9439

merged 13 commits into from
Feb 17, 2024

Conversation

hassnian
Copy link
Contributor

@hassnian hassnian commented Feb 16, 2024

PR Type

  • Bugfix
  • Feature
  • Refactoring

Context

❗️ Needs kodadot/workers#252

Did your issue had any of the "$" label on it?

  • Fill up your DOT address: Payout

Screenshot 📸

  • My fix has changed something on UI;

@kodabot
Copy link
Collaborator

kodabot commented Feb 16, 2024

SUCCESS @hassnian PR for issue #9422 which is assigned to you. Please wait for review and don't hesitate to grab another issue in the meantime!

@kodabot
Copy link
Collaborator

kodabot commented Feb 16, 2024

SUCCESS @hassnian PR for issue #9423 which is assigned to you. Please wait for review and don't hesitate to grab another issue in the meantime!

@kodabot
Copy link
Collaborator

kodabot commented Feb 16, 2024

SUCCESS @hassnian PR for issue #9428 which is assigned to you. Please wait for review and don't hesitate to grab another issue in the meantime!

@hassnian hassnian changed the title fix: Party kit followups #9423 fix: Party kit followups Feb 16, 2024
Copy link

netlify bot commented Feb 16, 2024

Deploy Preview for koda-canary ready!

Name Link
🔨 Latest commit fb293d5
🔍 Latest deploy log https://app.netlify.com/sites/koda-canary/deploys/65d0a33cd3458b0008120797
😎 Deploy Preview https://deploy-preview-9439--koda-canary.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@yangwao
Copy link
Member

yangwao commented Feb 16, 2024

probably this supposed to be me

telegram-cloud-photo-size-4-5945224384484589729-m

but on profile

image

@hassnian
Copy link
Contributor Author

probably this supposed to be me

telegram-cloud-photo-size-4-5945224384484589729-m

but on profile

image

I thought it was total spent on that specific drop, just fixed it, now it will show the same value as the profile page

@hassnian hassnian marked this pull request as ready for review February 17, 2024 06:08
@yangwao
Copy link
Member

yangwao commented Feb 17, 2024

found some niche bug

telegram-cloud-photo-size-4-5947351600181918965-x

plus one glitch

I have only one cursor on my desktop :D

Screen.Recording.2024-02-17.at.12.31.55.mov

@yangwao yangwao mentioned this pull request Feb 17, 2024
4 tasks
@yangwao
Copy link
Member

yangwao commented Feb 17, 2024

found some niche bug

ok double cursor it's official

image

@yangwao
Copy link
Member

yangwao commented Feb 17, 2024

or it's some state?

image

Copy link

codeclimate bot commented Feb 17, 2024

Code Climate has analyzed commit fb293d5 and detected 0 issues on this pull request.

View more on Code Climate.

Copy link

sonarcloud bot commented Feb 17, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@hassnian
Copy link
Contributor Author

since the worker is not updated , I'd say that is the issue

@yangwao
Copy link
Member

yangwao commented Feb 17, 2024

since the worker is not updated , I'd say that is the issue

should be deployed already

@yangwao
Copy link
Member

yangwao commented Feb 17, 2024

rounded numbers as three decimals are useless in this case and we can push it to canary

telegram-cloud-photo-size-4-5947351600181919001-m

@yangwao
Copy link
Member

yangwao commented Feb 17, 2024

Thanks!
pay 80 usd

@yangwao yangwao merged commit 4c49c65 into kodadot:main Feb 17, 2024
19 checks passed
@yangwao
Copy link
Member

yangwao commented Feb 17, 2024

😍 Perfect, I’ve sent the payout
💵 $80 @ 7.59 USD/DOT ~ 10.54 $DOT
🧗 16faLfsywwNATaEfbH2ah75dn6ZmctQWpMS5G4KFhbmj5hnD
🔗 0x70f4e8cb9a3efa37784b4f11f522b9e0769fe3f8c515ba0a20c2bcab83ceec16

🪅 Let’s grab another issue and get rewarded!
🪄 github.com/kodadot/nft-gallery/issues

@yangwao yangwao added the paid pull-request has been paid label Feb 17, 2024
This was referenced Feb 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
paid pull-request has been paid
Projects
None yet
3 participants