Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Final touches #245

Merged
merged 14 commits into from
Apr 15, 2023
Merged

Final touches #245

merged 14 commits into from
Apr 15, 2023

Conversation

vikiival
Copy link
Member

@vikiival vikiival commented Apr 15, 2023

  • ⚡ check if issuer is address
  • ⚡ emit ACCEPT if NFT is not pending in src/mappings/v2/buy.ts
  • ⚡ emit ACCEPT if NFT is not pending in src/mappings/v2/mint.ts
  • ⚡ emit ACCEPT if NFT is not pending in src/mappings/v2/send.ts
  • 🗑️ useless calculation of distribution
  • 🧼 prettier ;

Close #238

@socket-security
Copy link

New dependency changes detected. Learn more about Socket for GitHub ↗︎


👍 No new dependency issues detected in pull request

Bot Commands

To ignore an alert, reply with a comment starting with @SocketSecurity ignore followed by a space separated list of package-name@version specifiers. e.g. @SocketSecurity ignore foo@1.0.0 bar@* or ignore all packages with @SocketSecurity ignore-all

Pull request alert summary
Issue Status
Install scripts ✅ 0 issues
Native code ✅ 0 issues
Bin script shell injection ✅ 0 issues
Unresolved require ✅ 0 issues
Invalid package.json ✅ 0 issues
HTTP dependency ✅ 0 issues
Git dependency ✅ 0 issues
Potential typo squat ✅ 0 issues
Known Malware ✅ 0 issues
Telemetry ✅ 0 issues
Protestware/Troll package ✅ 0 issues

📊 Modified Dependency Overview:

⬆️ Updated Package Version Diff Added Capability Access +/- Transitive Count Publisher
@kodadot1/minimark@0.1.7-rc.3 0.1.7-rc.2...0.1.7-rc.3 None +0/-0 vikiival

@vikiival vikiival merged commit 41d1fb4 into main Apr 15, 2023
@vikiival vikiival deleted the final-touches branch April 15, 2023 14:52
@vikiival vikiival added the V2 Implementation of RMRK::2.0.0 label Jul 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
V2 Implementation of RMRK::2.0.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Mark that NFT was NESTed
1 participant