Skip to content
This repository has been archived by the owner on Jul 1, 2024. It is now read-only.

Better IPFS fetching #103

Merged
merged 4 commits into from
Oct 24, 2022
Merged

Better IPFS fetching #103

merged 4 commits into from
Oct 24, 2022

Conversation

vikiival
Copy link
Member

  • ➕ @kodadot1/minipfs
  • ⚡ fetchMetada uses obtain
  • ⚡ fetch metadata has new signature
  • 🔝 📦 minipfs@0.1.0

Thank you for your contribution to the KodaDot Indexer.
👇 _ Let's make a quick check before the contribution.

PR type

  • Bugfix
  • Feature
  • Refactoring

What's new?

  • PR closes #<issue_number>
  • This PR is required for kodadot/nft-gallery#<issue_number>

Before submitting Pull Request, please make sure:

  • My contribution builds clean without any errors or warnings
  • I've merged recent default branch -- main and I've no conflicts
  • I've tried to respect high code quality standards
  • I've didn't break any original functionality
  • I've posted a screenshot of demonstrated change in this PR

Optional

  • I've run the indexer and it hasn't failed
  • I've changed schema and performed a migration
  • I found edge cases

Screenshot

  • My contribution is a resolver so I have pic from playground

@yangwao
Copy link
Member

yangwao commented Oct 24, 2022

vikiival
vikiival commented Oct 24, 2022
View reviewed changes
Copy link
Member Author

@vikiival vikiival left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@vikiival vikiival merged commit 3bcff72 into main Oct 24, 2022
@yangwao yangwao deleted the super-ipfs branch October 24, 2022 12:56
@yangwao yangwao mentioned this pull request Oct 25, 2022
Closed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@vikiival @yangwao