Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Good vs bad #18

Closed
hollance opened this issue Nov 8, 2013 · 3 comments
Closed

Good vs bad #18

hollance opened this issue Nov 8, 2013 · 3 comments

Comments

@hollance
Copy link
Member

hollance commented Nov 8, 2013

I don't like the labels Good and Bad. That gives these choices a value judgment while they are not. Most of these choices -- such as where you put the braces -- are simply that: choices.

With people getting emotional over coding style guides, using labels such as Good and Bad isn't helping any.

@ndubbs
Copy link
Contributor

ndubbs commented Nov 9, 2013

After reading this and remember that we want to guide the readers, we should probably change these word choices.

How about Preferred or Recommended as a replacement for Good?

Not sure about Bad. What does everyone think?

@gregheo
Copy link
Contributor

gregheo commented Nov 9, 2013

I remember another guide I looked at just said "Like this: / Not this: ". "Not recommended" or "not preferred" sound a little weird to me.

Or, we could always just skip showing the "bad" examples altogether.

@ndubbs
Copy link
Contributor

ndubbs commented Nov 9, 2013

It is good to include the "bad" examples. There have been many times where I have found the tiniest nuance by comparing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants