Added Heap #4
Merged
Added Heap #4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Created Heap protocol and MaxHeap. I also included some basic tests.
|
I'll be happy to contribute a written description and a PriorityQueue implementation if everything looks good with this implementation. |
|
Looks very good! I'd really appreciate it if you could add a written explanation. :-) (Don't forget to include your name in the description, so you get some credit for your work.) |
Added a written description for Heap. Small terminology changes in Heap.swift
Added name next to Heap in main description README.
|
@kevinrandrup How you are running the tests ? Does playgroud supports XCTest ? |
|
@samirGuerdah It doesn't supposed XCTest. I just copy pasted the files into an Xcode project. |
|
Awesome, I've merged it and made a few small changes. Most importantly, I created an Xcode project for the unit tests. Thanks again, Kevin! |
hollance
pushed a commit
that referenced
this pull request
Feb 9, 2016
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I created a Heap protocol and implemented a MaxHeap. I also included some basic tests. They aren’t exhaustive by any means but I used them to verify everything is working correctly.