feat: use dynamic flow for protect yourself screen #40
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
darcien
commented
Mar 24, 2020
Comment on lines
+83
to
+90
| {screen.bodyTexts?.map((text) => ( | ||
| <BodyText key={text}> | ||
| {/* TODO: Should not use non-literal string with translate function */} | ||
| {t.frag(text, { | ||
| em: (text) => <EmText>{text}</EmText>, | ||
| })} | ||
| </BodyText> | ||
| ))} |
There was a problem hiding this comment.
The ionic app is using DOMPurify to render the em tag.
For now, I'll just ship it using t.frag even though it's not supposed to receive non-literal string.
There was a problem hiding this comment.
OK, I'll make a followup PR for parsing the actual html, but that won't be till later this week.
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to #37
Only replace the carousel in protect yourself.
Some screen property is not yet handled.
Preview:
