refactor: change type data Collection to Arrayable #13
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lakuapik
approved these changes
Dec 13, 2022
| @@ -135,10 +135,10 @@ public static function validateOrFail( | |||
| } | |||
|
|
|||
| /** | |||
| * Add data to response and transform according to its type. | |||
| * | |||
| * @param array|Collection|JsonResource|ResourceCollection $data | |||
There was a problem hiding this comment.
i think we should keep the collection just because its more popular rather than Arrayable
@param array|Arrayable|Collection|JsonResource|ResourceCollection
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR change type checker of data from
CollectiontoArrayable. This also will close #12 sinceCollectionandModelare implementArrayable.