hotfix for malfunctioning example #47
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Min Min <minmin@koderover.com>
landylee007
reviewed
Jun 30, 2021
examples/nginx/yaml/nginx.yaml
Outdated
| labels: | ||
| app: nginx3 | ||
| app: nginx | ||
| tier: backend | ||
| version: "{{.nginxVersion4}}" |
27149chen
approved these changes
Jul 1, 2021
lilianzhu
approved these changes
Jul 1, 2021
Signed-off-by: Min Min <minmin@koderover.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Min Min minmin@koderover.com
What this PR does / Why we need it:
This is a hotfix for a bugged example which will cause the ingress to lost its backend service.
Problem Summary:
The ingress rule service name does not match the real service name, causing a visiting problem for this example project.
What is changed and how it works?
What's Changed:
changed the service name to match the ingress rules.
How it Works:
More information
This change is