Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ExtraPoster support #15

Merged
merged 1 commit into from
Sep 3, 2017

Conversation

amillogical
Copy link

No description provided.

@Angelinas1
Copy link
Member

Are you shure that this workinkg ?
Window(Home).Property(SkinHelper.ListItem.Art.ExtraPoster)
I use Window(Home).Property(SkinHelper.ListItem.Art.Posters) and this working...
Why need new Property, plain to make download all poster in media folder ?

@marcelveldt
Copy link
Contributor

I think this is meant to be an alternative for extrafanart, so you can have rotating posters

@Angelinas1
Copy link
Member

Angelinas1 commented Aug 10, 2017

ok , but Window(Home).Property(SkinHelper.ListItem.Art.Posters) works fine as multiimage
http://imgur.com/DEoBrsD

@amillogical
Copy link
Author

amillogical commented Aug 11, 2017

@Angelinas1 Window(Home).Property(SkinHelper.ListItem.Art.ExtraPoster is working, I'm currently using it here (ex http://imgur.com/a/k5pwU)

I wasn't aware I could use SkinHelper.ListItem.Art.Posters as multiimage. How are you storing those poster images?

@Angelinas1
Copy link
Member

Angelinas1 commented Aug 11, 2017

Script don't download posters, create cache images and you can find in simple cache.db
Images are from https://fanart.tv/ (random)

For me dont working :(
Are for your changes need to have in mine media folder : /extraposter/poster0.poster1,poster2...
I don'have.....does I need to download mannual this Art ?
If this is condition to show Multiimage poster, then better is to Wait Marcel to create Automatic download posters in media folder...this work for music Art(AlbumArt)
Edit:
create extraposterfolder...and working OK, try to add automatic dowload for extraposter in folder_path

@amillogical
Copy link
Author

amillogical commented Aug 12, 2017

@Angelinas1, yes, it's the same as extrafanart currently. I've added the basic support in my library management software (emby) and setup downloading/reorganizing posters to the folders just as with emby's current extrafanart support.

Angelinas1 added a commit to Angelinas1/script.module.metadatautils that referenced this pull request Aug 12, 2017
Marcel if you include 
kodi-community-addons#15
This is add for that PR
@amillogical
Copy link
Author

Thank you @Angelinas1 I missed that download functionality that exists for extrafanart already.

@marcelveldt
Copy link
Contributor

I've decided to merge this in, I think it's a pretty valid addition and the code doesn't harm anyone.
@amillogical thanks for your contribution!

@marcelveldt marcelveldt merged commit 0f5f0f6 into kodi-community-addons:master Sep 3, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants