Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove non-existing buttons #20

Merged
merged 2 commits into from Dec 5, 2023
Merged

Conversation

KOPRajs
Copy link

@KOPRajs KOPRajs commented Dec 5, 2023

The same as kodi-game/game.libretro.pcsx-rearmed#26, remove buttons that actually don't exist on the controllers from the button map. I've also changed the order of the controllers to match the topology.xml.

In addition, I'm offering a new icon. I've created the icon for my own usage long time ago, because I don't like some aspects of the current bug icon (mainly it is actually a Mednafen icon and also it is the same for all former Mednafen emulator modules). The new icon is not perfect, but I was unable to find anything better. It is based on the video from the RetroArch's page on Steam (https://store.steampowered.com/app/1222630/RetroArch__Beetle_PSX/).

@KOPRajs
Copy link
Author

KOPRajs commented Dec 5, 2023

I also got one for Saturn, if you are interested:
Beetle_PSX
Beetle_Saturn

@garbear
Copy link
Member

garbear commented Dec 5, 2023

Love the new icons!

@garbear
Copy link
Member

garbear commented Dec 5, 2023

I've also changed the order of the controllers to match the topology.xml

This is OK, but the order in buttonmap.xml doesn't matter, only the order in topology.xml is used. For buttonmap.xml order I usually go in order of class/subclass, but like I said it doesn't really matter.

@KOPRajs
Copy link
Author

KOPRajs commented Dec 5, 2023

I've also changed the order of the controllers to match the topology.xml

This is OK, but the order in buttonmap.xml doesn't matter, only the order in topology.xml is used. For buttonmap.xml order I usually go in order of class/subclass, but like I said it doesn't really matter.

The new order is actually of class/subclass:

type="RETRO_DEVICE_ANALOG" subclass="0"
type="RETRO_DEVICE_ANALOG" subclass="1"

These two were 1, 0 before.

@garbear garbear merged commit f11362d into kodi-game:master Dec 5, 2023
1 check passed
@garbear
Copy link
Member

garbear commented Dec 5, 2023

Released a new version with the updated buttonmaps

@garbear
Copy link
Member

garbear commented Dec 6, 2023

The beetle-saturn icon looks great. Can you PR? I'm preparing a full add-on update for LibreELEC with all the new changes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants