DOSBox Hangs Kodi on Exit command

[zach-morris]

Version tested:

08:40:43.304 T:140735305183232  NOTICE: Starting Kodi (18.0-ALPHA1 Git:20180215-276e1a4). Platform: OS X x86 64-bit
08:40:43.304 T:140735305183232  NOTICE: Using Debug Kodi x64 build
08:40:43.304 T:140735305183232  NOTICE: Kodi compiled Feb 15 2018 by Clang 9.0.0 (clang-900.0.37) for OS X x86 64-bit version 10.8.0 (1080)
08:40:43.305 T:140735305183232  NOTICE: Running on Apple Inc. MacBookPro12,1 with OS X 10.11.6, kernel: Darwin x86 64-bit version 15.6.0
08:40:43.305 T:140735305183232  NOTICE: FFmpeg version/source: 3.4.1-Kodi
08:40:43.305 T:140735305183232  NOTICE: Host CPU: Intel(R) Core(TM) i5-5257U CPU @ 2.70GHz, 4 cores available

Issue: DOSBox hangs Kodi when typing EXIT in DOSBOX command prompt (The documented command to exit dosbox while its running). Expecting it to gracefully go back to Kodi. As an aside, I'm unsure how to normally get the in game OSD to pop up in DOSBox with my laptops mouse/keyboard (when no joystick is plugged in).

Log:

08:47:55.317 T:140735305183232   DEBUG: AddOnLog: DOS (DOSBox): ------------------------------------------------------------
08:47:55.317 T:140735305183232    INFO: GAME: ---------------------------------------
08:47:55.317 T:140735305183232    INFO: GAME: Base Width:   320
08:47:55.317 T:140735305183232    INFO: GAME: Base Height:  200
08:47:55.317 T:140735305183232    INFO: GAME: Max Width:    1024
08:47:55.317 T:140735305183232    INFO: GAME: Max Height:   768
08:47:55.317 T:140735305183232    INFO: GAME: Aspect Ratio: 1.333333
08:47:55.318 T:140735305183232    INFO: GAME: FPS:          60.000000
08:47:55.318 T:140735305183232    INFO: GAME: Sample Rate:  44100.000000
08:47:55.318 T:140735305183232    INFO: GAME: Region:       NTSC
08:47:55.318 T:140735305183232    INFO: GAME: ---------------------------------------
08:47:55.318 T:140735305183232   DEBUG: GAME: Audio sample rate is supported, no scaling or resampling needed
08:47:55.318 T:140735305183232   DEBUG: GAME: No in-game saves (save ram) to load
08:47:55.319 T:140735305183232   DEBUG: GAME: No in-game saves (rtc) to load
08:47:55.319 T:140735305183232   DEBUG: RetroPlayer[PLAYER]: Using game client game.libretro.dosbox
08:47:55.319 T:123145303453696   DEBUG: Thread GameLoop start, auto delete: false
08:47:55.319 T:140735305183232   DEBUG: PERIPHERALS: Event poll handle activated
08:47:55.319 T:140735305183232   DEBUG: RetroPlayer[PLAYER]: Closing OSD via speed change (1.000000)
08:47:55.319 T:140735305183232   DEBUG: ------ Window Deinit () ------
08:47:55.319 T:140735305183232   DEBUG: OnPlayBackStarted: CApplication::OnPlayBackStarted
08:47:55.323 T:140735305183232   DEBUG: ------ Window Init () ------
08:47:55.323 T:140735305183232   DEBUG: Alloc resources: 0.00ms  (0.00 ms skin load)
08:47:55.326 T:123145308819456   DEBUG: CGUIInfoManager::SetCurrentGame()
08:47:55.326 T:123145306673152   DEBUG: CAnnouncementManager - Announcement: OnPlay from xbmc
08:47:55.327 T:123145306673152   DEBUG: GOT ANNOUNCEMENT, type: 1, from xbmc, message OnPlay
08:47:55.327 T:123145306673152   DEBUG: CAnnouncementManager - Announcement: OnChanged from xbmc
08:47:55.327 T:123145306673152   DEBUG: GOT ANNOUNCEMENT, type: 1024, from xbmc, message OnChanged
08:47:55.331 T:140735305183232   DEBUG: CDirectoryProvider[addons://sources/game/]: refreshing..
08:47:55.337 T:123145319092224   DEBUG: Skin Helper Widgets --> Kodi_Monitor: sender xbmc - method: Player.OnPlay  - data: {"item":{"type":"unknown"},"player":{"playerid":-1,"speed":1}}
08:47:55.340 T:123145303453696   DEBUG: RetroPlayer[VIDEO]: Creating video stream - format 0RGB32, 720x400, 0 deg
08:47:55.340 T:123145303453696    INFO: RetroPlayer[RENDER]: Configuring format 0RGB32, 720x400, 0 deg
08:47:55.340 T:123145319092224   DEBUG: Skin Helper Widgets --> Kodi_Monitor: sender xbmc - method: Unknown.OnChanged  - data: null
08:47:55.340 T:123145303453696    INFO: RetroPlayer[AUDIO]: Creating audio stream, sample rate = 44100
08:47:55.345 T:140735305183232    INFO: RetroPlayer[RENDER]: Renderer configured on first frame
08:47:55.356 T:123145303453696    INFO: AddOnLog: DOS (DOSBox): Resolution changed 0x0 => 720x400
08:47:55.360 T:140735305183232   DEBUG: Activating window ID: 12906
08:47:55.361 T:140735305183232   DEBUG: ------ Window Deinit (Home.xml) ------
08:47:55.361 T:140735305183232   DEBUG: FreeVisualisation() done
08:47:55.362 T:140735305183232   DEBUG: ------ Window Init (VideoFullScreen.xml) ------
08:47:55.362 T:140735305183232    INFO: Loading skin file: VideoFullScreen.xml, load type: KEEP_IN_MEMORY
08:47:55.364 T:140735305183232   DEBUG: Skin file /Applications/Kodi_Retroplayer.app/Contents/Resources/Kodi/addons/skin.estuary/xml/VideoFullScreen.xml loaded in 1.67ms
08:47:55.364 T:140735305183232   DEBUG: Alloc resources: 1.92ms  (1.92 ms skin load)
08:47:55.364 T:140735305183232   ERROR: RetroPlayer[RENDER]: Creating renderer for OpenGL
08:47:55.364 T:140735305183232   DEBUG: RetroPlayer[RENDER]: Configuring buffer pool
08:47:55.377 T:123145303453696   DEBUG: RetroPlayer[RENDER]: Creating render buffer for buffer pool
08:47:55.417 T:123145307209728   DEBUG: CActiveAE::ClearDiscardedBuffers - buffer pool deleted
08:47:55.422 T:123145318019072   DEBUG: Skin Helper Service --> Kodi_Monitor: sender xbmc - method: Player.OnPlay  - data: {"item":{"type":"unknown"},"player":{"playerid":-1,"speed":1}}
08:47:55.430 T:123145318019072   DEBUG: Skin Helper Service --> Kodi_Monitor: sender xbmc - method: Unknown.OnChanged  - data: null
08:47:55.481 T:123145303453696   DEBUG: RetroPlayer[RENDER]: Creating render buffer for buffer pool
08:47:55.645 T:140735305183232   DEBUG: Inhibiting OS screen saver
08:47:56.712 T:140735305183232   DEBUG: Keyboard: scancode: 0x0e, sym: 0x0065, unicode: 0x0065, modifier: 0x0
08:47:56.712 T:140735305183232   DEBUG: AddOnLog: DOS (DOSBox): Controller "game.controller.keyboard" key "e" (RETROK_e) modifier 0x00000000: down
08:47:56.779 T:140735305183232   DEBUG: Keyboard: scancode: 0x0e, sym: 0x0065, unicode: 0x0000, modifier: 0x0
08:47:56.779 T:140735305183232   DEBUG: AddOnLog: DOS (DOSBox): Controller "game.controller.keyboard" key "e" (RETROK_e) modifier 0x00000000: up
08:47:56.862 T:140735305183232   DEBUG: Keyboard: scancode: 0x07, sym: 0x0078, unicode: 0x0078, modifier: 0x0
08:47:56.862 T:140735305183232   DEBUG: AddOnLog: DOS (DOSBox): Controller "game.controller.keyboard" key "x" (RETROK_x) modifier 0x00000000: down
08:47:56.979 T:140735305183232   DEBUG: Keyboard: scancode: 0x07, sym: 0x0078, unicode: 0x0000, modifier: 0x0
08:47:56.979 T:140735305183232   DEBUG: AddOnLog: DOS (DOSBox): Controller "game.controller.keyboard" key "x" (RETROK_x) modifier 0x00000000: up
08:47:56.995 T:140735305183232   DEBUG: Keyboard: scancode: 0x22, sym: 0x0069, unicode: 0x0069, modifier: 0x0
08:47:56.995 T:140735305183232   DEBUG: AddOnLog: DOS (DOSBox): Controller "game.controller.keyboard" key "i" (RETROK_i) modifier 0x00000000: down
08:47:57.062 T:140735305183232   DEBUG: Keyboard: scancode: 0x22, sym: 0x0069, unicode: 0x0000, modifier: 0x0
08:47:57.063 T:140735305183232   DEBUG: AddOnLog: DOS (DOSBox): Controller "game.controller.keyboard" key "i" (RETROK_i) modifier 0x00000000: up
08:47:57.112 T:140735305183232   DEBUG: Keyboard: scancode: 0x11, sym: 0x0074, unicode: 0x0074, modifier: 0x0
08:47:57.112 T:140735305183232   DEBUG: AddOnLog: DOS (DOSBox): Controller "game.controller.keyboard" key "t" (RETROK_t) modifier 0x00000000: down
08:47:57.162 T:140735305183232   DEBUG: Keyboard: scancode: 0x11, sym: 0x0074, unicode: 0x0000, modifier: 0x0
08:47:57.162 T:140735305183232   DEBUG: AddOnLog: DOS (DOSBox): Controller "game.controller.keyboard" key "t" (RETROK_t) modifier 0x00000000: up
08:47:57.262 T:140735305183232   DEBUG: Keyboard: scancode: 0x24, sym: 0x000d, unicode: 0x000d, modifier: 0x0
08:47:57.263 T:140735305183232   DEBUG: AddOnLog: DOS (DOSBox): Controller "game.controller.keyboard" key "enter" (RETROK_RETURN) modifier 0x00000000: down
08:47:57.329 T:140735305183232   DEBUG: Keyboard: scancode: 0x24, sym: 0x000d, unicode: 0x0000, modifier: 0x0
08:47:57.329 T:140735305183232   DEBUG: AddOnLog: DOS (DOSBox): Controller "game.controller.keyboard" key "enter" (RETROK_RETURN) modifier 0x00000000: up

[garbear]

Attempted to fix in libretro/dosbox-libretro#47, but that didn't go anywhere so we added 0001-Fix-infinite-loop-on-exit.patch. This should be fixed now.

[zach-morris]

Confirmed working with version

-----------------------------------------------------------------------
16:24:38.837 T:140735187836928  NOTICE: Starting Kodi (18.0-BETA1 Git:20180817-6d3f248cdf). Platform: OS X x86 64-bit
16:24:38.838 T:140735187836928  NOTICE: Using Debug Kodi x64 build
16:24:38.838 T:140735187836928  NOTICE: Kodi compiled Aug 17 2018 by Clang 9.0.0 (clang-900.0.37) for OS X x86 64-bit version 10.9.0 (1090)
16:24:38.839 T:140735187836928  NOTICE: Running on Apple Inc. MacBookPro12,1 with OS X 10.11.6, kernel: Darwin x86 64-bit version 15.6.0
16:24:38.839 T:140735187836928  NOTICE: FFmpeg version/source: 4.0.2-Kodi
16:24:38.839 T:140735187836928  NOTICE: Host CPU: Intel(R) Core(TM) i5-5257U CPU @ 2.70GHz, 4 cores available