Internal depends #101
Merged
Internal depends #101
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Allow override URL and INTERNAL build of libretro for PPA
allow override RCHEEVOS_URL and enable internal rcheevos lib build for PPA offline usage
Error was: Error copying directory from "libretro-common/include" to "include/libretro-common".
Error was:
In file included from src/client.cpp:8:
Cheevos.h:10:10: fatal error: rcheevos/rcheevos.h: No such file or directory
10 | #include "rcheevos/rcheevos.h"
| ^~~~~~~~~~~~~~~~~~~~~
Error was:
[ 33%] Linking CXX shared library game.libretro.so
/usr/bin/ld: build/depends/lib/librcheevoslib.a(hash.c.o):
warning: relocation against `verbose_message_callback' in read-only section `.text'
/usr/bin/ld: build/depends/lib/librcheevoslib.a(hash.c.o):
relocation R_X86_64_PC32 against symbol `verbose_message_callback' can not be used when making a shared object; recompile with -fPIC
/usr/bin/ld: final link failed: bad value
garbear
force-pushed
the
internal-depends
branch
from
832d88d
to
4481435
Compare
|
Rebased on #102, CI is looking good again |
|
Also ping @wsnipex for review, this starts our journey of fixing all the missing dependency issues in our ppa |
|
Cool, looks like v19 is still broken, I'll see if I can backport |
|
no use for the PPA, older versions won't get built or published anymore |
|
Then touch it I don't. |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR is a continuation of #93. I cherry-picked all the work and rebased on the Nexus branch.
How has this been tested?
Starting to test now.
Jenkins looks good: https://jenkins.kodi.tv/blue/organizations/jenkins/kodi-game%2Fgame.libretro/detail/PR-101/1/pipeline