Import HLSL shader presets #10
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This imports only the used files from https://github.com/libretro/common-shaders.git at commit c2b31d5ac59796aa70b3d0900416258c018010ec.
This updates the used shader preset files to commit 86cfa146a8dfddf6377ddb5dbcff552feae2e5bf.
|
Rebased on #9. Lets see how CI does. EDIT: win32 and win64 are good! |
|
Good to merge? |
gusandrianos
approved these changes
Mar 18, 2023
|
This PR replaces VelocityRa/xbmc#24. Did I ever do a similar PR for glsl shaders? If not, you'll have to do the same for glsl what I did here. |
|
You didn't. I'll check if the presets aren't updated regularly and if so I'll make a PR similar to this one. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR replaces the git submodules with the actual files, and only the ones we use.
Git submodules aren't handled by Kodi's build system, and even if they were, we don't want to ship 10s of megabytes of unused shaders.
However, the HLSL shaders aren't really being developed these days, so we can just copy/paste the files directly.
I checked and, in the last 6 years, only a few files have changed. I left the changes as a separate commit in case they need to be inspected.
Related PRs
Replaces VelocityRa/xbmc#24
How has this been tested?
Tested with the following commit: 9408b746c1d64c8774abfed9d8ef983257d14781
Test builds with this change, and removing the shaders from the xbmc repo, are in progress.