Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

jsoncpp1.8.3 deprecated function update #77

Merged
merged 1 commit into from Nov 29, 2017

Conversation

fuzzard
Copy link
Contributor

@fuzzard fuzzard commented Nov 26, 2017

This changes jsoncpp deprecated methods (Fastwriter, getformatederror, reader) to the
non deprecated versions.

If you can merge #76 first, and ill rebase and fixup the version/changelog on this one after.

Runtime tested on mac os with the changes from #76 applied to a win10 argustv server. No apparent regressions from my minimal testcases.

Copy link
Member

@ksooo ksooo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Don't know jsoncpp. Cannot say anything to the correctness of the changes wrt jsoncpp. The code changes at language level look sane to me.

@ksooo
Copy link
Member

ksooo commented Nov 29, 2017

needs rebase.

This changes jsoncpp deprecated methods (Fastwriter, getformatederror, reader) to the
non deprecated versions.
@fuzzard
Copy link
Contributor Author

fuzzard commented Nov 29, 2017

rebased

@ksooo
Copy link
Member

ksooo commented Nov 29, 2017

Thanks.

@ksooo ksooo merged commit 1a48789 into kodi-pvr:master Nov 29, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants