Isengard backports #103
Merged
Isengard backports #103
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
It does not make much sense to inlcude Jalle19@02c6644 as GetBufferTimeStart and GetBufferTimeEnd never get called in Isengard. |
|
@ksooo that's too bad, that commit was the most PITA to cherry-pick ;-) So should I drop it? |
|
Yes, makes really no sense for Isengard, sorry. Please drop it. |
Jalle19
force-pushed
the
isengard-updates
branch
2 times, most recently
from
f5a97ab
to
c3e6231
Compare
|
@ksooo dropped the timeshift commit and added the VFS fix. Haven't build tested any of this yet so this is not yet for merging. |
Jalle19
force-pushed
the
isengard-updates
branch
from
1c14039
to
4cf4163
Compare
|
@ksooo I added the latest fix, I think we're good to go now. I'll run some test builds on Jenkins before PRing the bump. |
|
Your button. |
|
Tested in production, everything seems to work. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@ksooo I picked the ones that weren't related to any of the API changes. I'll add #100 to the mix once we've merged it into master.