Support for autorec/timerec update (new htsp v25 methods) #145
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -248,8 +253,104 @@ PVR_ERROR AutoRecordings::SendAutorecAdd(const PVR_TIMER &timer) | |||
|
|
|||
| PVR_ERROR AutoRecordings::SendAutorecUpdate(const PVR_TIMER &timer) | |||
| { | |||
| /* Note: there is no "updateAutorec" htsp method, thus delete + add. */ | |||
| if (m_conn.GetProtocol() >= 25) | |||
There was a problem hiding this comment.
Since the implementation is so differing between these different HTSP versions, maybe it would be clearer to delegate the actual logic to separate functions, i.e. something like this (pseudo):
AutoRecordings::SendAutoRecUpdate(timer) {
if (htsp < 25) {
SendAutoRecUpdateLegacy();
} else {
SendAutorecUpdateActual();
}
}
Naming scheme is obviously up for debate.
ksooo
changed the title
|
updated |
|
diff looks quite big but that's because of the retention -> lifetime renaming |
|
@Glenn-1990 Please add a changelog entry and thos one is ready for merging. Thanks for this contribution. |
|
@ksooo done ;-) |
|
@ksooo your button |
ksooo
added a commit
that referenced
this pull request
Jan 4, 2016
Support for autorec/timerec update (new htsp v25 methods)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since htsp v25 it's possible to do proper autorec/timerc update, so let's use it.
Unfortunately, the retention field was also changed.
https://github.com/tvheadend/tvheadend/blob/master/src/htsp_server.c#L981
So I think the best thing we can do is using "retention" for htsp < 25 en "removal" for newer versions.
Removal is the main lifetime setting in recent tvh master builds, "retention" is set on "remove when file removed"