[htsp v27] implement server based playcount and playposition #308
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ksooo
requested changes
Jun 3, 2017
src/Tvheadend.cpp
Outdated
| int CTvheadend::GetPlayPosition ( const PVR_RECORDING &rec ) | ||
| { | ||
| if (m_conn.GetProtocol() < 27) | ||
| return PVR_ERROR_NOT_IMPLEMENTED; |
There was a problem hiding this comment.
According to the API documentation, this line should read return -1;.
src/Tvheadend.cpp
Outdated
| return it->second.GetPlayPosition(); | ||
| } | ||
|
|
||
| return PVR_ERROR_INVALID_PARAMETERS; |
There was a problem hiding this comment.
According to the API documentation, this line should read return -1;.
|
@Glenn-1990 do you think it would be a good idea to let the user choose (addon settings) whether server-side playcount/Position shall be used? Also, version bump and changelog is missing. |
|
@ksooo Addressed your comments. I also added an advanced setting in case users don't like the new behaviour. |
ksooo
approved these changes
Jun 4, 2017
|
Nice. Thank you very much for this contribution. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It's been a while, tvheadend 4.2 is out and it includes improved playstatus support.
Kodi master does have an issue that needs to be fixed as well before this code will work as expected.
xbmc/xbmc#12226
The big advantage:
Start watching a recording in the living room and resume watching in the bedroom etc.
@ksooo