https support

[rubdos]

Will eventually resolve #369.

[rubdos]

I haven 't tested this yet, will do that later... Just wanted this out somewhere already :)

[rubdos]

Also fixed the clang build error.

[rubdos]

Mind that I still didn't have a chance to test this, so please do so before merging :'-)

[Jalle19]

I don't have HTTPS set up so I can't really test

[rubdos]

I tested it working, but the text for the button in the settings is still empty.

[rubdos]

I tested it working, but the text for the button in the settings is still empty.

Could someone give me a hint how I can update the necessary translation files for this?

[Gee1111]

this also works for the windows addon ?

[rubdos]

this also works for the windows addon ?

I wouldn't know how that'd be different. But hey, it's Windows, better test it :-)

[Jalle19]

Could someone give me a hint how I can update the necessary translation files for this?

You only need to update en_GB, the rest are handled later on through Transifex. If you're using another language in Kodi you might wanna switch to the en_GB while developing so you can see your changes.

[ksooo]

please change settings id to first available general settings id (30011) and supply a string for it.

[ksooo]

@rubdos have you seen that we requested changes?

[rubdos]

Excuse me for the late reply. Have been quite busy.

W.r.t. base branch: are you sure we don't want to backport this into Leia? It's quite an annoying bug imo.

[jobrien2001]

@ksooo Any chance to review this? :D

[rubdos]

Apparently I never fixed the translation ID. That's done now. I also rebased against Matrix.

[trimethia]

@ksooo Any chance to review this?

[AlwinEsch]

Related to xbmc/xbmc#17307, not forget a rebase of request to allow further Jenkins use!

git remote add upstream https://github.com/kodi-pvr/pvr.hts
git fetch upstream
git rebase upstream/Matrix

[rubdos]

It's only the third time I'm rebasing this now, I would really appreciate to know what still has to be done to get this merged.

[ksooo]

Please update the changelog and increase addon minor version and we are ready to go.

[ksooo]

Please update the changelog and increase addon minor version and we are ready to go.

Well not really. Kodi default language is en_gb, not en_us. So, please add the new settings string to pvr.hts/resources/language/resource.language.en_gb/strings.po and remove it from pvr.hts/resources/language/resource.language.en_us/strings.po as translations are handled via Transifex, not Github.

[ksooo]

See my comments

[rubdos]

See my comments

I don't see any comments in the diff linked by "View changes".

I've changed the translation to en_gb, added the changelog entry, incremented the minor version. Would you like me to squash everything together?

[ksooo]

Yes, please squash to a single commit.

[rubdos]

Comments addressed, squashed!

[ksooo]

Thanks for your contribution.