API: GetTimerTypes: Heap-allocate TimerType instances to avoid stack overflow #68
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ksooo
force-pushed
the
heap-alloc-timer-types
branch
from
eae0364
to
95cfe38
Compare
|
Shove 'em in, we're in alpha at the moment after all. I haven't runtime tested either since I hadn't upgraded my HTPC to Isengard until a few days ago, which means I'll most likely get around to it soon. |
|
👍 |
|
@ksooo will do so once home - looks good in general - thx for beeing so quick here :) |
|
@Memphiz Any good? |
|
gimme 10 mins |
|
beer garden temperatures here - had to set my priorities :D |
|
@ksooo confirmed that this fixes the crash :) - thx |
ksooo
added a commit
that referenced
this pull request
Jul 22, 2015
API: GetTimerTypes: Heap-allocate TimerType instances to avoid stack overflow
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@Memphiz could you please take a look whether this works for you (MacOS)?