Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issues with newly added credit tags (actor, director, writer) #268

Closed
augustas2 opened this issue Aug 22, 2019 · 4 comments
Closed

Issues with newly added credit tags (actor, director, writer) #268

augustas2 opened this issue Aug 22, 2019 · 4 comments

Comments

@augustas2
Copy link

Here is the file where the tags for xml is described: https://github.com/xbmc/xbmc/blob/master/xbmc/addons/kodi-addon-dev-kit/include/kodi/xbmc_epg_types.h

According to line 91, field strCast can be multiple actors separated by comma or any other separator. So by current Addon code, only first actor tag is taken...

Also XMLTV format states, that every actor must be specified in every new <actor>First Last Name</actor> tag. XMLTV format example here: http://wiki.xmltv.org/index.php/XMLTVFormat

So current code is buggy, as you need a loop threw all <actor/> XMLTV tags and append them into one string.
Same rule for director and writer, as the XMLTV file may contain multiple writers and directors.

@phunkyfish
Copy link
Member

Example here: #269

@2small will use something like this to fix it.

@Sorien
Copy link

Sorien commented Aug 22, 2019

@phunkyfish
Copy link
Member

Fixed in #269

@phunkyfish
Copy link
Member

And #275

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants