New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support multiple credits elements, firstAired, year, star rating, episode-num in epg entry, readme update, multiple display-names's and matching channels, plus bugfixes #269
Conversation
@2small something like what's here. This needs to be tested, it may be completely wrong. |
I will check to later, maybe at weekend or early. |
53096eb
to
7f73372
Compare
56913c3
to
026cba9
Compare
I'm sorry, I'm late <programme channel="amc" start="20190826123000 +0000" stop="20190826143000 +0000">
<title>xXx (2002)</title>
<sub-title>Nuotykių / Trileris / Veiksmo - JAV</sub-title>
<desc>Vin Diesel and action merge superbly, don't they? All guns are blazing in this wild thriller as extreme sports athlete Xander Cage is recruited by the government for a special mission.</desc>
<category>Movie / Drama</category>
<icon src="https://cdn.tvstart.com/img/programme/thumb/372030.jpg" />
<credits>
<director>Rob Cohen</director>
<director>Second Director</director>
<writer>Writer1, Writer2</writer>
<actor>Vin Diesel, Asia Argento</actor>
<actor>Marton Csokas</actor>
<actor>Samuel L. Jackson</actor>
<actor>Michael Roof, Richy Müller, Werner Daehn, Petr Jákl</actor>
</credits>
</programme> we can see <programme channel="amc" start="20190826123000 +0000" stop="20190826143000 +0000">
<title>xXx (2002)</title>
<sub-title>Nuotykių / Trileris / Veiksmo - JAV</sub-title>
<desc>Vin Diesel and action merge superbly, don't they? All guns are blazing in this wild thriller as extreme sports athlete Xander Cage is recruited by the government for a special mission.</desc>
<category>Movie / Drama</category>
<icon src="https://cdn.tvstart.com/img/programme/thumb/372030.jpg" />
<credits>
<director>Rob Cohen</director>
<director>Second Director</director>
<writer>Writer1, Writer2</writer>
<actor>Vin Diesel / Asia Argento / Marton Csokas / Samuel L. Jackson / Michael Roof / Richy Müller / Werner Daehn / Petr Jákl</actor>
</credits>
</programme> |
Cool, so working as expected. Might add star-rating, rating, year and episode number to this PR if you can test? |
for pvr.iptvsimple/src/PVRIptvData.cpp Lines 873 to 875 in 026cba9
for my is interesting |
ok, well I will add the commits to this PR and maybe you can test what you can. I like the idea of premiere/new but I don’t think that is something that is possible right now. |
@2small @Sorien can you review and test this? If you are happy with it I'll add the necessary files and remove the WIP tag. |
WOW, tomorrow i tested this code with examples :) |
i can test just on windows episode-num with system xmltv_ns is ok as well |
@allixx can you also test this on Leia? |
Great, thanks @Sorien. There are quite a few fixes, test what you can. |
…first, next tvg-name and then channel name find order
9677235
to
449df16
Compare
Ready to go @ksooo, appveyor may take 24 hours though ;) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
almost. ;-)
449df16
to
062fccb
Compare
Ok, NOW it's ready! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good job.
With kodi-pvr#269 there are two regex which are evaluated on every function call. In my case loading time was increased from 800msec to 10sec. This PR replaces those regex with static one. For Leia branch.
With kodi-pvr#269 there are two regex which are evaluated on every function call. In my case loading time was increased from 800msec to 10sec. This PR replaces those regex with static one. For Leia branch.
With kodi-pvr#269 there are three regex which are evaluated on every function call. In my case loading time was increased from 800msec to 10sec. This PR replaces those regex with static one and brings time down to 530msec.
With kodi-pvr#269 there are three regex which are evaluated on every function call. In my case loading time was increased from 800msec to 10sec. This PR replaces those regex with static one and brings time down to 530msec.
v3.8.0