Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support multiple credits elements, firstAired, year, star rating, episode-num in epg entry, readme update, multiple display-names's and matching channels, plus bugfixes #269

Merged
merged 15 commits into from Sep 4, 2019

Conversation

phunkyfish
Copy link
Member

@phunkyfish phunkyfish commented Aug 22, 2019

v3.8.0

  • Support multiple display-names and case insensitive tvg-id is always first, next tvg-name and then channel name find order
  • Support full timeshift range of -12 to +14 hours
  • Some providers incorrectly use tvg-ID instead of tvg-id
  • Channel groups not being clared when reading next channel
  • support episode-num for both xmltv_ns and onscreen systems in epg entry
  • Update readme for settings, supported M3U and XMLTV formats and genres
  • support star rating in epg entry
  • support firstAired and year in epg entry
  • Update OSX build scripts
  • support multiple actor/director/writers elements in epg entry
  • URLEncode and append .png ext for remote logos built from channel name
  • Added: Timing for Playlist and EPG load

@phunkyfish
Copy link
Member Author

@2small something like what's here. This needs to be tested, it may be completely wrong.

@ghost
Copy link

ghost commented Aug 22, 2019

I will check to later, maybe at weekend or early.

src/PVRIptvData.cpp Outdated Show resolved Hide resolved
@phunkyfish phunkyfish force-pushed the multiactor branch 2 times, most recently from 56913c3 to 026cba9 Compare August 23, 2019 12:48
@ghost
Copy link

ghost commented Aug 26, 2019

I'm sorry, I'm late

<programme channel="amc" start="20190826123000 +0000" stop="20190826143000 +0000">
<title>xXx (2002)</title>
<sub-title>Nuotykių / Trileris / Veiksmo - JAV</sub-title>
<desc>Vin Diesel and action merge superbly, don't they? All guns are blazing in this wild thriller as extreme sports athlete Xander Cage is recruited by the government for a special mission.</desc>
<category>Movie / Drama</category>
<icon src="https://cdn.tvstart.com/img/programme/thumb/372030.jpg" />
<credits>
<director>Rob Cohen</director>
<director>Second Director</director>
<writer>Writer1, Writer2</writer>
<actor>Vin Diesel, Asia Argento</actor>
<actor>Marton Csokas</actor>
<actor>Samuel L. Jackson</actor>
<actor>Michael Roof, Richy Müller, Werner Daehn, Petr Jákl</actor>
</credits>
</programme>

Screenshot from 2019-08-26 08-15-11

we can see director and writer kodi show joined with /,
but actors has stripped
if with my older xmltv format, where actor is joined with /

<programme channel="amc" start="20190826123000 +0000" stop="20190826143000 +0000">
<title>xXx (2002)</title>
<sub-title>Nuotykių / Trileris / Veiksmo - JAV</sub-title>
<desc>Vin Diesel and action merge superbly, don't they? All guns are blazing in this wild thriller as extreme sports athlete Xander Cage is recruited by the government for a special mission.</desc>
<category>Movie / Drama</category>
<icon src="https://cdn.tvstart.com/img/programme/thumb/372030.jpg" />
<credits>
<director>Rob Cohen</director>
<director>Second Director</director>
<writer>Writer1, Writer2</writer>
<actor>Vin Diesel / Asia Argento / Marton Csokas / Samuel L. Jackson / Michael Roof / Richy Müller / Werner Daehn / Petr Jákl</actor>
</credits>
</programme>

Screenshot from 2019-08-26 08-26-39

@phunkyfish
Copy link
Member Author

Cool, so working as expected.

Might add star-rating, rating, year and episode number to this PR if you can test?

@ghost
Copy link

ghost commented Aug 26, 2019

star-rating, rating, year can be, but kodi default skin estuary not showing :(
https://github.com/xbmc/xbmc/blob/Leia/addons/skin.estuary/xml/DialogPVRInfo.xml#L52

for episode-num is difficult, because many values and system, popular:
onscreen -> S02E05
xmltv_ns -> 1.4. (minus 1 for season, episode and part)
in the pvr.iptvsimple need set integer value for season, episode, part
part i think not showing kodi skin

tag.iSeriesNumber = 0; /* not supported */
tag.iEpisodeNumber = 0; /* not supported */
tag.iEpisodePartNumber = 0; /* not supported */

for my is interesting new or premiere tag, this tag is used for live shows or live sport events, and kodi can be add to show label bell or red/green dot, but this functionality used for record :(
couldn't find addition flags or property where can be set it

@phunkyfish
Copy link
Member Author

phunkyfish commented Aug 26, 2019

ok, well I will add the commits to this PR and maybe you can test what you can.

I like the idea of premiere/new but I don’t think that is something that is possible right now.

@phunkyfish phunkyfish changed the title WIP - support multiple actor elements in epg entry WIP - Support multiple credits elements, firstAired, year, star rating, episode-num in epg entry, readme update, multiple display-names's and matching and groups bugfix Aug 27, 2019
@phunkyfish
Copy link
Member Author

@2small @Sorien can you review and test this?

If you are happy with it I'll add the necessary files and remove the WIP tag.

@ghost
Copy link

ghost commented Aug 27, 2019

WOW, tomorrow i tested this code with examples :)

@Sorien
Copy link

Sorien commented Aug 27, 2019

i can test just on windows
cast, director & writer looks ok i'll try test more just have to update xmltv generator.

episode-num with system xmltv_ns is ok as well

@phunkyfish phunkyfish changed the title WIP - Support multiple credits elements, firstAired, year, star rating, episode-num in epg entry, readme update, multiple display-names's and matching and groups bugfix WIP - Support multiple credits elements, firstAired, year, star rating, episode-num in epg entry, readme update, multiple display-names's and matching channels, plus bugfixes Aug 27, 2019
@phunkyfish phunkyfish changed the title WIP - Support multiple credits elements, firstAired, year, star rating, episode-num in epg entry, readme update, multiple display-names's and matching channels, plus bugfixes Support multiple credits elements, firstAired, year, star rating, episode-num in epg entry, readme update, multiple display-names's and matching channels, plus bugfixes Aug 27, 2019
@phunkyfish
Copy link
Member Author

@allixx can you also test this on Leia?

@phunkyfish
Copy link
Member Author

i can test just on windows
cast, director & writer looks ok i'll try test more just have to update xmltv generator.

episode-num with system xmltv_ns is ok as well

Great, thanks @Sorien. There are quite a few fixes, test what you can.

@phunkyfish
Copy link
Member Author

Ready to go @ksooo, appveyor may take 24 hours though ;)

Copy link
Member

@ksooo ksooo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

almost. ;-)

src/PVRIptvData.cpp Outdated Show resolved Hide resolved
src/PVRIptvData.cpp Outdated Show resolved Hide resolved
@phunkyfish
Copy link
Member Author

Ok, NOW it's ready!

Copy link
Member

@ksooo ksooo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job.

@phunkyfish phunkyfish merged commit d075870 into kodi-pvr:Leia Sep 4, 2019
@phunkyfish phunkyfish deleted the multiactor branch September 4, 2019 16:47
vpeter4 added a commit to vpeter4/pvr.iptvsimple that referenced this pull request Sep 22, 2019
With kodi-pvr#269 there are two regex which are evaluated on every function call. In my case loading time was increased from 800msec to 10sec. This PR replaces those regex with static one.
For Leia branch.
@vpeter4 vpeter4 mentioned this pull request Sep 22, 2019
vpeter4 added a commit to vpeter4/pvr.iptvsimple that referenced this pull request Sep 22, 2019
With kodi-pvr#269 there are two regex which are evaluated on every function call. In my case loading time was increased from 800msec to 10sec. This PR replaces those regex with static one.
For Leia branch.
@vpeter4 vpeter4 mentioned this pull request Sep 22, 2019
vpeter4 added a commit to vpeter4/pvr.iptvsimple that referenced this pull request Sep 22, 2019
With kodi-pvr#269 there are three regex which are evaluated on every function call. In my case loading time was increased from 800msec to 10sec. This PR replaces those regex with static one and brings time down to 530msec.
vpeter4 added a commit to vpeter4/pvr.iptvsimple that referenced this pull request Sep 22, 2019
With kodi-pvr#269 there are three regex which are evaluated on every function call. In my case loading time was increased from 800msec to 10sec. This PR replaces those regex with static one and brings time down to 530msec.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants