Provide media headers to inputstream.adaptive if channel does not explicitly set them.

[basilgello]

Fixes the HTTP 403 error on segment download with several
IPTV providers, as suggested by Markus Pfau (@peak3d)
here: xbmc/inputstream.adaptive#411

[phunkyfish]

Ok, I think you are doing more than you need to with this. It looks like you strip the headers to just add them in the same way again. Can you give some examples of URLs and what the value of stream_headers ends up being?

[phunkyfish]

Really you should update the AddHeader call to optionally support URL encoding. I think your code to encode the headers could still be simpler.

[phunkyfish]

I still think you should add a boolean to

pvr.iptvsimple/src/iptvsimple/utilities/StreamUtils.cpp

Line 245 in 53c7c97

std::string StreamUtils::AddHeaderToStreamUrl(const std::string& streamUrl, const std::string& headerName, const std::string& headerValue)

And then do the URL encoding as part pr that function. You could change the name to something else if you wish. Like AddHeader and the argument just called a simple string name or maybe headerTarget.

[phunkyfish]

Ok, this is looking really good. Just some minors.

You also need to update the addon.xml.in and changelog.txt. There are chagnelog entries in both files.

For the version number you need to update minor number. I.e. in major.minor.patch the middle one as you've added a new feature.

Well done ;)

[basilgello]

Technically it is a bugfix so I changed the patch instead of minor :) With timeshift occupying 4.12.0 in the PRs list, would be good to make it live ;)

Thanks for review! :)

[phunkyfish]

LGTM

[phunkyfish]

And thanks for contributing!