Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Coverity fixes #11

Merged
merged 6 commits into from Jun 28, 2015
Merged

Coverity fixes #11

merged 6 commits into from Jun 28, 2015

Conversation

margro
Copy link
Member

@margro margro commented Jun 20, 2015

This PR fixes various coverity issues

@MartijnKaijser
Copy link
Member

@hudokkow @margro , RC1 is coming up. Is this something that should/can be included?

@Jalle19
Copy link
Contributor

Jalle19 commented Jun 26, 2015

@MartijnKaijser most likely
@margro can you bump the version/changelog before we merge?

@hudokkow
Copy link
Contributor

No objections from me. I've been doing fixes for other addons but my time this week and next is close to zero (parents visiting).
BTW, any way to extract a report from coverity? The report page drives me nuts. Every single action is sloooowww.

@margro, I started from the bottom, wmc, vuplus, etc. No need to duplicate work.

@MartijnKaijser
Copy link
Member

@hudokkow no export that i know of. Sometimes it is slow but most of the time it's quite ok.

@margro
Copy link
Member Author

margro commented Jun 28, 2015

@Jalle19: done
@MartijnKaijser: yes, the code changes are minimal and I tested here on Linux and Windows. Should be safe for RC1
@hudokkow: I've only update my addons so as far a I'm aware, we didn't do duplicate work.
Furthermore, I've assigned all Coverity issues that I solved to myself before solving them...

MartijnKaijser added a commit that referenced this pull request Jun 28, 2015
@MartijnKaijser MartijnKaijser merged commit 210229e into kodi-pvr:master Jun 28, 2015
@MartijnKaijser
Copy link
Member

since Isengard is already branch for all PVR add-ons, should this be included in that release it also needs to be merged in that branch

@margro margro deleted the coverity-fixes branch February 21, 2016 12:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants