Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to PVR addon API v4.0.0 #23

Merged
merged 1 commit into from
Sep 14, 2015
Merged

Conversation

ksooo
Copy link
Member

@ksooo ksooo commented Sep 14, 2015

This PR implements all changes needed to properly support PVR Addon API v4.0.0, including a PVR addon micro version bump.

Details can be found here: xbmc/xbmc#8005

ksooo added a commit that referenced this pull request Sep 14, 2015
Update to PVR addon API v4.0.0
@ksooo ksooo merged commit 3f49cde into kodi-pvr:master Sep 14, 2015
@ksooo ksooo deleted the pvr-api-4-0-0 branch September 15, 2015 12:08
@margro
Copy link
Member

margro commented Sep 19, 2015

Why did you change the internal addon fields from int to unsigned int? The -1 values are for a reason since 0 is a valid id from the backend. This breaks the funtionality of the addon!
Please don't ever do this again in a "version bump"!

@ksooo
Copy link
Member Author

ksooo commented Sep 19, 2015

Nice to hear something from someone who seems to feel responsible for this addon. Great!

Maybe you could start to follow the PVR Addon API discussions in the forum and the xbmc PRs that are flagged with "PVR" and "API change", then you can raise your voice in time. You can be assured that we ofc not break things by intention.

@ksooo
Copy link
Member Author

ksooo commented Sep 19, 2015

BTW: Any plans, to implement the series recording changes introduced by 2.0.0?

@ksooo
Copy link
Member Author

ksooo commented Nov 24, 2015

The -1 values are for a reason since 0 is a valid id from the backend.
@margro Any chance that you come up with a PR fixing this?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants