Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Various updates for v18 #90

Merged
merged 15 commits into from Aug 15, 2018
Merged

Various updates for v18 #90

merged 15 commits into from Aug 15, 2018

Conversation

margro
Copy link
Member

@margro margro commented Aug 15, 2018

v3.5.4

  • Remove Windows XP support
  • Don't update the Kodi connection state when trying to connect in the background thread. This prevents pop-ups every minute when the backend is down.
  • Report readable connection state changes instead of numbers
  • Remove the deprecated PositionLiveStream() and PositionRecordedStream() functions
  • Replace TVServerXBMC plugin references by TVServerKodi
  • Accessing %PROGRAMDATA% for TV thumbnails is only possible for Windows Desktop
  • Replace all GetTickCount() calls by GetTickCount64() for UWP compatibility
  • Don't report an empty connection string in the log
  • Fixed: seek in recordings was broken in v18
  • Fixed: recording playback as rtsp stream via internal Kodi videoplayer
  • Fixed: Restore file playback via internal Kodi videoplayer on Windows (PVR addon by-pass)
  • GetChannelGroupMembers: add iSubChannelNumber support (PVR API 5.8.0)

@margro margro added this to the v18 milestone Aug 15, 2018
@margro margro self-assigned this Aug 15, 2018
@margro
Fix recording stream times. This fixes seek actions after PVR API 5.8.0
dea7ee8 
It implements GetStreamTimes() for recordings
@margro
Recordings: playback fixes:
c79a0f9 
- Fix recording playback as rtsp stream via internal Kodi videoplayer
- Restore file playback via internal Kodi videoplayer on Windows (PVR addon bypass)
@margro
GetChannelGroupMembers: add iSubChannelNumber support (PVR API 5.8.0)
87884c1
@margro
Update pvr.mediaportal to v3.5.4 (various v18 updates)
28dbe03
@margro margro merged commit ca4f4db into kodi-pvr:master Aug 15, 2018
Rechi
Rechi reviewed Aug 18, 2018
View reviewed changes
src/pvrclient-mediaportal.cpp
@@ -661,30 +701,18 @@ PVR_ERROR cPVRClientMediaPortal::GetChannels(ADDON_HANDLE handle, bool bRadio)
if( !SendCommand2(command, lines) )
return PVR_ERROR_SERVER_ERROR;

#ifdef TARGET_WINDOWS
#ifdef TARGET_WINDOWS_DESKTOP
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this broke uwp

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Whoops. Should be fixed with #91. Thanks for letting me know...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Rechi Rechi Rechi left review comments

Assignees

@margro margro

Labels
bug Cleanup enhancement
Projects
None yet
Milestone
v18
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@margro @Rechi