Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

3.3.4 #38

Merged
merged 3 commits into from Sep 15, 2015

Conversation

@janbar
Copy link
Member

commented Sep 15, 2015

Fix testing constant of api 4.0.0
Sync upstream cppmyth 2.3.1

janbar added a commit that referenced this pull request Sep 15, 2015
@janbar janbar merged commit ee57d91 into kodi-pvr:master Sep 15, 2015
@ksooo

This comment has been minimized.

Copy link
Collaborator

commented on src/pvrclient-mythtv.cpp in 6241eb3 Sep 15, 2015

As I mentioned in the original API 4.0.0 PR, where you already suggested this change, I think this is not correct. Values < PVR_TIMER_NO_EPG_UID are not allowed. Kodi core will not create values less than PVR_TIMER_NO_EPG_UID. Thus, you only need to check for > PVR_TIMER_NO_EPG_UID.

@ksooo

This comment has been minimized.

Copy link
Collaborator

commented on pvr.mythtv/changelog.txt in 4476f08 Sep 15, 2015

Why did you delete v3.3.3? IMO, you should keep 3.3.3 changelog and just add 3.3.4 changelog.

@janbar janbar deleted the janbar:3.3.4 branch Sep 23, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.