Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Needs API 4.2.0 support #38

Closed
MilhouseVH opened this issue Feb 12, 2016 · 10 comments
Closed

Needs API 4.2.0 support #38

MilhouseVH opened this issue Feb 12, 2016 · 10 comments

Comments

@MilhouseVH
Copy link

This patch might suffice as a band aid: http://nmacleod.com/public/oebuild/patches/01_pvr_vuplus_420.txt (shamelessly nicked from @stefansaraev)

Otherwise should this add-on be put on notice for marking as broken?

@MartijnKaijser
Copy link
Member

see
#35

@stefansaraev
Copy link

this patch is just a hack to make it compile (EDIT: run, without the patch it compiles fine but fails at runtime) and is not complete. it will work only for users who dont do recordings.

@MilhouseVH
Copy link
Author

OK fine, so presumably this add-on is no longer maintained? I'll drop it from future builds in that case. Thanks both.

@stefansaraev
Copy link

I meant it will work for livetv playback, no clue what side effects it might have on timeshift/recordings :)

@MilhouseVH
Copy link
Author

The add-on can't be loaded without this patch due to the missing symbol issue, if there's no plans to upgrade to 4.2.0 then this add-on is surely dead.

@MartijnKaijser
Copy link
Member

i wonder why it only fails to build on win32 while the rest is just happy. shouldn't it just fail?

@MartijnKaijser
Copy link
Member

Besides it only fails for nightlies and release is still many months away so you shouldn't give a damn that this isn't include for the next months. If people really care some one will pop up to maintain it

@stefansaraev
Copy link

i wonder why it only fails to build on win32 while the rest is just happy. shouldn't it just fail?

no. it will compile fine but fail at runtime

btw #28 (comment) :)

@MilhouseVH
Copy link
Author

I don't give a damn. I just wanted to know if this would be updated or not because as it stands it's broken. For now I'll stop building it. Thanks.

@MartijnKaijser
Copy link
Member

@stefansaraev on windows it fails ;)
http://jenkins.kodi.tv/job/WIN-32/7827/

kodiplatform.lib(XMLUtils.cpp.obj) : MSIL .netmodule or module compiled with /GL found; restarting link with /LTCG; add /LTCG to the link command line to improve linker performance

Creating library pvr.vuplus.lib and object pvr.vuplus.exp

client.cpp.obj : error LNK2001: unresolved external symbol _IsRealTimeStream

pvr.vuplus.dll : fatal error LNK1120: 1 unresolved externals

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants