New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[RFC] Rename "VuPlus" PVR client addon to Enigma2 or something else for Kodi? #28
Comments
@jdembski, as the original author of this addon for Kodi, what are your options today on such a name change? |
If this goes through, please make sure you don't end up with the same Ubuntu package naming snafu like we did with pvr.hts. @wsnipex pinging you just in case. |
I don't have a problem with changing its name - the reason why I named it "vuplus" in the first place was because I The KODI sub-forum should be named "enigma2" and not just enigma, as the addon does not support enigma1 boxes. In general it may seem that the development stopped on this addon - which is kind of true as I'm just using it to see sports broadcasts in my home cinema, so I do not really care about features like timeshift, advanced timer handling or zapping times. So if anyone wants to step up and pick up the further development for this addon - please go ahead. |
-1 btw, thanks @jdembski for the excellent code base. EDIT: please read "before Jarvis final is out". Sorry, I'm tired... |
@Hedda, yes and a few more. Timeshifting is working. BTW, I need your help. |
@hudokkow @jdembski Thanks for the update! I have got an follow-up question but it might be a little too much off-topic so you don't have to answer it but I will at it anyway, and that follow-up question this: Have you or anyone tested to compile and run your Enigma2 PVR client addon for Kodi running nativly on a hardware set-top box that runs the Enigma2 OS image? That is, wil you be able to run both the Kodi (GUI) application AND your Enigma2 Enigma2 PVR client addon locally on a hardware box that is runing an Enigma2 based image for a all-in-one DVR device solution without streaming video over the network from an Enigma2 box o Kodi running on a a other non-Enigma2 based computer? As you probably know by now, WeTek now have Enigma2 based images/ditros available from the OE-Alliance for the WeTek Play (see https://github.com/wetek-enigma/ and http://wetekforums.com/vb5/forum/wetek-play/enigma-2 ), and they even got Kodi running on nativly on some of those Enigma2 based images. And also Vu+ have ported Kodi so that it runs nativly on their newer Enigma2 based set-top boxes, though they do not yet hardware accelerated video decoding working yet in Kodi's internal video player, (see for example http://www.vuplus-community.net/board/forums/xbmc-black-hole.115/ ). |
@hudokkow do you have news on your new/replacement PVR client addon for Enigma2 backends? Maybe you could even hint of an ETA for pushing and publish it to a public repo here on GitHub? |
Will be available for Krypton alphas and maybe for Jarvis when it hits final. Haven't decided yet. |
@hudokkow, great news, we hispasat users have a common problem we cannot stream most of the channels on kodi with vuplus add-on, can you have a look and maybe fix this problem in your add-on? Many thanks |
@hudokkow did you ever release the new plugin? |
@hudokkow any news or this or your new PVR client addon for Enigma2 / Vu Plus and its name? |
He made a lot of changes to the existing plugin. I’m maintaining it now. |
I havn’t looked at what is involved in changing the name. If it means breaking the addon for a lot of users I’m not sure I’d be keen on it. Or is it just the displayed name you are looking to change? I maintain this in my spare time so would rather not spend cycles on something if it doesn’t have to happen or if there is a simpler solution. |
@Hedda changing this cosmetically doesn't appear to have an impact which is great news. I'll create the PR over the next few days. |
@phunkyfish Changing only the display name cosmetically should be more than enough I think. That is, the name change would really be made to make it more clear to the end-users (not to make it clear for developers). The idea was to make people know that this addon is not dedicated only for PVR-boxes manufactured by VuPlus but instead for all PVR-boxes that are based on the Enigma2 software platform (which is used by many other manufacturers too, and in fact, VuPlus was not even the first to use Enigma2 software platform, the first was Dreambox as developed by Dream Multimedia). |
Makes perfect sense, same reasoning as XBMC->Kodi Name will be Enigma2 |
Good decision! Maybe it would be different if XBMC Foundation was sponsored by Vu+ but since it is not ;) |
@phunkyfish Submitted pull request #105 and pull request #106 to reflect this name change. |
Please, would you consider renaming the "VuPlus" PVR client addon to Enigma or something else?
Arguments for this is that it is is not a specific Vu+ PVR client addon but actually an "Enigma2" PVR client addon. As Vu+ (written as VuPlus) is a specific company that makes set-top boxes based on the Enigma2 open source platform, and the "VuPlus" PVR client addon does not only work with Vu+ set-top boxes but actually works with any Enigma2 based set-top boxes, including the popular Dreambox, DBox2, SAB, and Amiko boxes from different competing companies, as well as many more Enigma2 based set-top boxes from other manufacturers. Even one of Kodi's official sponsors, WeTek, have Enigma2 based images available or their WeTek Play set-top box, so they too can use this addon which is still named the "VuPlus" PVR client addon.
To add to that argument is that Vu+ is not even the original developer of the Enigma2 open source platform, as that is DreamMedia who makes the Dreambox series. So originally it would even have made more sense to name the PVR client addon "Dreambox" than "VuPlus", but now that is not either true as DreamMedia have very recently abandoned the Enigma2 open source platform for all their new set-top box as they have switched so use a propriatary OS which they call "Dreambox OS".
Call it bikeshedding or OCD is you will, but having this addon keeping the name "VuPlus" is very bad form, and I think that it could make it look like the Kodi team is only supporting set-top boxes from Vu+ as a company for whichever reason, and not all Enigma2 based set-top boxes which is more in the spirits of open source philosofy, and even more so now that WeTek too is offering several Enigma2 based images for their WeTek Play device which just so happen is known to be in the possession of many Kodi developers because them being a sponsor of the project.
Regardless it would really make a lot of sense to rename this addon for Kodi to "Enigma2" or just "Enigma", or whatever. Only thing that does does not make sense is the addon being named "VuPlus" as it is today.
Also note subforum in Kodi community is called "Enigma" http://forum.kodi.tv/forumdisplay.php?fid=167
EDIT: For reference read this Kodi forum thread http://forum.kodi.tv/showthread.php?tid=214947
The text was updated successfully, but these errors were encountered: