-
Notifications
You must be signed in to change notification settings - Fork 55
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor and fix #113
Refactor and fix #113
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As it is unreviewable I trust you on the refactoring changes. Just minor comments for the rest.
Ok, ready to go. |
Should be ready now |
@ksooo can you approve this? 😉 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
bool Epg::IsInitialEpgCompleted() | ||
{ | ||
m_readHandle = XBMC->OpenFile(INITIAL_EPG_READY_FILE.c_str(), 0); | ||
byte buf[1]; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah, I see the problem.
I will fix as soon as I’m home from work.
… On 15 Oct 2018, at 17:00, Rechi ***@***.***> wrote:
@Rechi commented on this pull request.
In src/enigma2/Epg.cpp:
> + : m_channels(channels), m_channelGroups(channelGroups), m_entryExtractor(entryExtractor)
+{
+ InitialiseEpgReadyFile();
+}
+
+void Epg::InitialiseEpgReadyFile()
+{
+ m_writeHandle = XBMC->OpenFileForWrite(INITIAL_EPG_READY_FILE.c_str(), true);
+ XBMC->WriteFile(m_writeHandle, "Y", 1);
+ XBMC->CloseFile(m_writeHandle);
+}
+
+bool Epg::IsInitialEpgCompleted()
+{
+ m_readHandle = XBMC->OpenFile(INITIAL_EPG_READY_FILE.c_str(), 0);
+ byte buf[1];
@phunkyfish this break windows, see https://jenkins.kodi.tv/view/Addons/job/kodi-pvr/job/pvr.vuplus/job/master/2/execution/node/191/log/
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub, or mute the thread.
|
v3.12.5
Hopefully the last large refactor ;)