Load config if enabled

[phunkyfish]

v3.15.2

• Fixed: Only load Season info extractor and genre mappers config when enabled, fixes Only load Season info extractor and genre mappers config when enabled #136
• Fixed: 3.15.1 dont load/work on old DM800se, fixes 3.15.1 dont load/work on old DM800se #139
• Fixed: Missing default value from timeshift buffer path, fixes Missing default value from timeshift buffer path #140
• Fixed: Channel Group Member Order not preserved, fixes Channel Group Member Order not preserved #141

[phunkyfish]

Adding an extra fix for old STB's will let you know once it's there.

[phunkyfish]

@ksooo ready for reivew now. Just some small fixes.

[phunkyfish]

Actually, one other fix for channel group ordering.

[phunkyfish]

Ready to review again @ksooo

[phunkyfish]

@ksooo would be great if have a little bit of time to review this. I've added some debug logging to help with diagnosing what's going on with #145. Once that's in I can create a bug report for Libreeelec.

[kid63]

Hello @phunkyfish and @ksooo,
yeah, would be great because of the dreambox-fix, none of the Dreamboxes has got a distroversion implemented in the webinterface. Got a dm920 and 3.15.1 doesn't work for Dreambox-Users at all, not just the old ones. As a workaround i tared the 3.14 and extract it back, but that's unsatisfying.

Regards
kid

[MilhouseVH]

@phunkyfish I'll include this PR in the next LibreELEC nightly (Saturday night, #1201), hopefully we can get you the information you need.

[phunkyfish]

Thanks @MilhouseVH

[phunkyfish]

@MilhouseVH thanks again for including. This did indeed help me find the issue.

There was a new option added at some point to PVR settings "Synchronise channel groups with backend(s)". It would appear that in stock kodi this gets enabled by default, whereas in libreelec it does not or something to that effect.

[phunkyfish]

@ksooo this PR has been soak tested for several days now so should be ok to put through.

[MilhouseVH]

@phunkyfish ah yes, LibreELEC disables that option in appliance.xml, here. Not entirely sure why it is disabled, but it's something that has been disabled for 3 years (original commit back in OpenELEC days). I'll ask around and see if anyone from the LE team remembers.

[MilhouseVH]

So far nobody knows why it was disabled (although it's late on Sunday night... :))

For now I'll revert the LibreELEC commit in nightly test builds so that pvrmanager.syncchannelgroups is enabled as it is in stock Kodi, and we can gauge the effect.

[phunkyfish]

Here’s the thing though. It worked just fine until a couple of months ago, can’t pin point exactly when but it’s possible I was carrying it enabled from an old config for some time. Let’s hope there are not any serious side effects 🤞 Thanks

…

On 9 Dec 2018, at 23:19, MilhouseVH ***@***.***> wrote: So far nobody knows why it was disabled (although it's late on Sunday night... :)) For now I'll revert the LibreELEC commit in nightly test builds so that pvrmanager.syncchannelgroups is enabled as it is in stock Kodi, and we can gauge the effect. — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub, or mute the thread.

[kid63]

Hi,

unfortunately #137 ignores the Favourite-Bouqets from Dreamboxes, only Freetv is displayed. Was working in 3.14, that's the latest version it worked, because 3.15.1 wasn't for Dreamboxes. Tested it with OSMC.

cu

[phunkyfish]

In this version on the channels tab you need to select the favourites (as first or last group) in addition to All Bouquets. It was the only way I could get it work across all hardware and images. Not all images process favourites in the same way.

As I don’t have a dream box I didn’t test that specific hardware but it shouldn't be different.

Also, on OSMC you'll need to check you are not effected by this bug #145. So if you enable that option and select the favourites in the channels tab you should be ok.

Let me know if it still doesn't work @kid63

[kid63]

Thanks for pointing me in the right direction, will have a look. :)

@phunkyfish
Everything's ok, just had to reconfigure.

[Matthias1992]

Hey guys,
I still have the same problem with,
Kodi (18.0-RC3 Git:20181210-c6107e5). Platform: Linux x86 64-bit
and an DM800SE

Enigma2 Client: pvr.vuplus - LoadDeviceInfo Could not parse e2distroversion from result!

But I don't get @phunkyfish what do you mean to fix is with the Bouquets.
A longer explain would be nice,
just a kodi noob :)
Matthias

[phunkyfish]

This PR covers a number of the bug fixes. The bouquets stuff is not related to the fix for e2distroversion

[ksooo]

LGTM. Maybe you could make some more of the strings you've changed const. I only commented on two of them, but saw more candidates in the diff...

[phunkyfish]

@MilhouseVH thanks for including in nightlies, it should come via master now.