New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Change version to 4.5.1 related to Kodi API update #241
Conversation
462c6e9
to
5449183
Compare
@ksooo on Appveyor what do you think? We have travis so it makes sense I guess. Thoughts? You are also adding Xcode 10.2 so I think 4.6.0 is correct. |
As nothing changes I would only bump to 4.5.1. |
Ok. |
@AlwinEsch I assume this PR can go in once it passes review. I.e. it's not waiting on any other PRs to be merged? And yes, you can add appveyor. |
I make tomorrow quickly the Leia changes and then comes this in :) |
Are you back porting this to Leia? I thought this change was Matrix only? |
Only the "update CMakeLists.txt to version 3.5". Have to see that I get through to Leia, thought at the beginning of only 20 addons are. Now it's already 173. Unfortunately, many did not work properly and even had massive compile and link bugs. Then I try these changes made by Leia to push in the matrix branches (without commit difference). |
I understand, makes sense. Thanks for explaining. Can I help in any way? |
This needed for reworked header checks by Kodi's addon build system.
94d906d
to
139e7aa
Compare
Were you going to add Appveyor here too? |
Is updated and also request on Leia now. |
Once I test this I assume it’s not waiting on anything else to be merged? |
Yes can be in, only with appveyor must be something on his website enabled to work with them |
ae1a090
to
2adab61
Compare
Looks good and no issues on testing. |
2adab61
to
4b49592
Compare
Great, thanks. I will merge and create a release shortly. |
Further is on .travis.yml the xcode changed to 10.2 to have equal with
Kodi itself.
This version change is related to xbmc/xbmc#16431 and xbmc/xbmc#16452
(it use
#include <kodi_vfs_types.h>
)How do you see it, with version 4.6.0 OK?
Is not actually a change in the code.
As another question, does it make sense to add "appveyor.yml" here as well?
EDIT: Maybe better to make 4.5.1? There is for me mostly a fix.