Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change version to 4.5.1 related to Kodi API update #241

Merged
merged 6 commits into from Aug 22, 2019

Conversation

AlwinEsch
Copy link
Contributor

@AlwinEsch AlwinEsch commented Aug 16, 2019

Further is on .travis.yml the xcode changed to 10.2 to have equal with
Kodi itself.

This version change is related to xbmc/xbmc#16431 and xbmc/xbmc#16452
(it use #include <kodi_vfs_types.h>)

How do you see it, with version 4.6.0 OK?
Is not actually a change in the code.

As another question, does it make sense to add "appveyor.yml" here as well?

EDIT: Maybe better to make 4.5.1? There is for me mostly a fix.

@phunkyfish
Copy link
Member

@ksooo on Appveyor what do you think? We have travis so it makes sense I guess. Thoughts?

You are also adding Xcode 10.2 so I think 4.6.0 is correct.

@Rechi
Copy link
Contributor

Rechi commented Aug 17, 2019

As nothing changes I would only bump to 4.5.1.

@phunkyfish
Copy link
Member

Ok.

pvr.vuplus/addon.xml.in Outdated Show resolved Hide resolved
pvr.vuplus/addon.xml.in Outdated Show resolved Hide resolved
pvr.vuplus/changelog.txt Outdated Show resolved Hide resolved
@phunkyfish phunkyfish changed the title Change version to 4.6.0 related to Kodi API update Change version to 4.5.1 related to Kodi API update Aug 18, 2019
@phunkyfish phunkyfish changed the title Change version to 4.5.1 related to Kodi API update Change version to ~~4.6.1~~ 4.5.1 related to Kodi API update Aug 18, 2019
@phunkyfish phunkyfish changed the title Change version to ~~4.6.1~~ 4.5.1 related to Kodi API update Change version to 4.5.1 related to Kodi API update Aug 18, 2019
@phunkyfish
Copy link
Member

phunkyfish commented Aug 19, 2019

@AlwinEsch I assume this PR can go in once it passes review. I.e. it's not waiting on any other PRs to be merged?

And yes, you can add appveyor.

@AlwinEsch
Copy link
Contributor Author

I make tomorrow quickly the Leia changes and then comes this in :)

@phunkyfish
Copy link
Member

Are you back porting this to Leia? I thought this change was Matrix only?

@AlwinEsch
Copy link
Contributor Author

Only the "update CMakeLists.txt to version 3.5".

Have to see that I get through to Leia, thought at the beginning of only 20 addons are. Now it's already 173.

Unfortunately, many did not work properly and even had massive compile and link bugs.

Then I try these changes made by Leia to push in the matrix branches (without commit difference).
Therefore, I still hold off.

@phunkyfish
Copy link
Member

phunkyfish commented Aug 19, 2019

I understand, makes sense. Thanks for explaining. Can I help in any way?

@phunkyfish
Copy link
Member

Were you going to add Appveyor here too?

@AlwinEsch
Copy link
Contributor Author

Is updated and also request on Leia now.

@phunkyfish
Copy link
Member

Once I test this I assume it’s not waiting on anything else to be merged?

@AlwinEsch
Copy link
Contributor Author

Yes can be in, only with appveyor must be something on his website enabled to work with them

appveyor.yml Outdated Show resolved Hide resolved
@phunkyfish
Copy link
Member

Looks good and no issues on testing.

@phunkyfish
Copy link
Member

Great, thanks. I will merge and create a release shortly.

@phunkyfish phunkyfish merged commit 4b5ec27 into kodi-pvr:Matrix Aug 22, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants