-
Notifications
You must be signed in to change notification settings - Fork 23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement PVR API 5.0.0 #36
Conversation
@@ -1142,6 +1142,9 @@ PVR_ERROR Pvr2Wmc::GetRecordings(ADDON_HANDLE handle) | |||
xRec.iEpgEventId = atoi(v[18].c_str()); | |||
} | |||
|
|||
/* TODO: PVR API 5.0.0: Implement this */ | |||
xRec.iChannelUid = PVR_CHANNEL_INVALID_UID; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This field should already be available in the response message at array position 17
So this could be replaced with the following:
// Kodi PVR API 5.0.0 adds Channel ID field
if (v.size() > 18)
{
xRec.iChannelUid = atoi(v[17].c_str());
}
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Cool. Feel free to change that once this PR got merged (later today).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done, thanks for the continued API work! #37
For details refer to xbmc/xbmc#8736
Before this PR can go in, xbmc/xbmc#8736 must be merged.