Implemented GetRecordingEdl #65
Conversation
resync with upstream
sync with upstream
|
background: https://forum.kodi.tv/showthread.php?tid=338806 |
|
Wondering why nothing is happening. Did I do something wrong on the PR? Or is it just too late to get it into kodi18? |
| <addon | ||
| id="pvr.wmc" | ||
| version="2.4.3" | ||
| version="2.4.5" |
There was a problem hiding this comment.
Why is the version number increased by 2?Should read 2.4.4 imo.
There was a problem hiding this comment.
2.4.4 was used as the version to test. I'm guessing to be safe it was incremented again to ensure any machines with the dev/test version of the add-on get the final version included with Kodi.
There was a problem hiding this comment.
Hmm, fairly uncommon as now everybody is wondering what happend to 2.4.4.
There was a problem hiding this comment.
I'd like to keep the version to 2.4.5. Basically the for the reason sbthomas said, but there are also comment changes between the tested version and this one.
There was a problem hiding this comment.
Also... I don't know how to 'squash down the changes to a single commit'. If that's required I would need to do some research, or a little guidance.
| @@ -1,4 +1,7 @@ | |||
| 2.4.0 | |||
| 2.4.5 | |||
There was a problem hiding this comment.
I didn't think 2.4.4 needed to be there since it was the same as 2.4.5 and very few people used 2.4.4.
| @@ -21,5 +21,5 @@ | |||
|
|
|||
| inline std::string PVRWMC_GetClientVersion() | |||
| { | |||
| return "2.4.0"; // ALSO CHANGE IN REV NUMBER in 'pvr.wmc/addon.xml.in' | |||
| return "2.4.5"; // ALSO CHANGE IN REV NUMBER in 'pvr.wmc/addon.xml.in' | |||
|
??? |
|
I gave up. Will try to clean up with a new PR |
|
Okay. 2.4.4, please. |
No description provided.