klient: fix client deadlock on session failure #177
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rjeczalik
force-pushed
the
send-error
branch
3 times, most recently
from
4b41baa
to
adbeef4
Compare
When underlying streaming transport (session) was unexpectedly closed, client hangs when no timeout was set. We should instead expect underlying transport to fail and forward the error to the caller instead, so it does not hang, no matter whether timeout was used or not.
When session is not yet opened then open=false,closed=false, when session is closed then open=false,closed=true. Check first whether session is closed, so proper error is returned.
| if x.isClosed() { | ||
| return ErrSessionClosed | ||
| } | ||
|
|
||
| if !x.isOpened() { |
There was a problem hiding this comment.
not related with this PR:
grammatically it should be isOpen() since it is adjective
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When underlying streaming transport (session) was unexpectedly
closed, client hangs when no timeout was set.
We should instead expect underlying transport to fail and forward
the error to the caller instead, so it does not hang, no matter
whether timeout was used or not.